feat: show combiner for properties of an object #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulatulis
commented
Dec 30, 2021
| /> | ||
| )) | ||
| .add('anyOf-array-schema', () => ( | ||
| .add('oneOf-array-schema', () => ( |
There was a problem hiding this comment.
this change is unrelated to this issue, but I also updated the story names to match the files/schema
paulatulis
commented
Dec 30, 2021
| /> | ||
| )) | ||
| .add('anyOf-array-schema2', () => ( | ||
| .add('oneOf-array-schema2', () => ( |
There was a problem hiding this comment.
this change is unrelated to this issue, but I also updated the story names to match the files/schema
Nezteb
approved these changes
Dec 30, 2021
|
Yeah, I would be curious to hear from Nauman what would he expect in the select options 😅 If there is no array, you see only options in select, without anyOf/oneOf:
|
@mpodlasin I thought we already covered the case for anyOf/OneOf showing for non array cases. |
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address #9513
Because the combiner is a level deep, it shows up in each choice. Is that too busy for someone's eyes?