fix: show guideline to right props on hover if present #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
screenshot looks good! gonna try running storybook locally. I'm curious how it handles on touch screens or with keyboard focus. |
|
Good call! I'll check too |
|
So obv no hover on touch screen, but will show on tap in this case 🤷♂️
|
|
On the other side of things, I have a whole lot of ideas re keyboard accessibility / navigation that I'd like to visit at some point. |
|
(Keyboard accessibility is a big ask obviously, but touch support is simple enough.) Edit: Looks like |
|
🎉 This PR is included in version 4.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help visually connect prop to extra values on right if there are any.