Skip to content

feat: depend on mosaic 1.0.0 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 23, 2021
Merged

feat: depend on mosaic 1.0.0 #153

merged 5 commits into from
Jun 23, 2021

Conversation

@marcelltoth
Copy link
Contributor

Nice to have for #141

@marcelltoth marcelltoth requested review from a team June 22, 2021 09:33
@marcelltoth marcelltoth self-assigned this Jun 22, 2021
@marcelltoth marcelltoth requested a review from paulatulis June 22, 2021 09:33
marcelltoth
marcelltoth commented Jun 22, 2021
View reviewed changes
package.json
"@stoplight/markdown-viewer": "^5.0.0-beta.5",
"@stoplight/mosaic": "^1.0.0-beta.59",
"@stoplight/mosaic": "^1.0.0",
"@stoplight/mosaic-code-viewer": "^1.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missing. Needed for (peer of) MDV.

@mallachari
Copy link

Hmm, what's wring with those types? Is it some react incompatibility?

@paulatulis
Copy link
Contributor

Should the test_and_release workflow pass or is that something that can be ignored?

Also, is there somewhere I could see this in action? If not, since it's a nice-to-have, I will defer to @mallachari's review since he is probably more familiar with what this affects.

@marcelltoth
Copy link
Contributor Author

Should the test_and_release workflow pass or is that something that can be ignored?

It absolutely should, updated now!

Also, is there somewhere I could see this in action? If not, since it's a nice-to-have, I will defer to @mallachari's review since he is probably more familiar with what this affects.

Unfortunately no. JSV doesn't have PR environments AFAIK so you have to run it locally. Also there should be no visible change compared to current beta.

@marcelltoth marcelltoth merged commit 89b4b5e into beta Jun 23, 2021
@marcelltoth marcelltoth deleted the feat/mosaic-1 branch June 23, 2021 14:37
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulatulis paulatulis Awaiting requested review from paulatulis

1 more reviewer

@mallachari mallachari mallachari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marcelltoth marcelltoth

Labels

released on @beta released team/undefined

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marcelltoth @mallachari @paulatulis @stoplight-bot