feat: accept JSON Schema Draft 6 & Draft 7 #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
feat/newer-drafts-beta
branch
2 times, most recently
from
f65812a to
bd7a4d3
Compare
P0lip
force-pushed
the
feat/newer-drafts-beta
branch
from
bd7a4d3 to
2eb6acd
Compare
P0lip
commented
Apr 27, 2021
| </div> | ||
| </div> | ||
| </div> | ||
| <div> |
There was a problem hiding this comment.
I hope the order doesn't matter for you.
P0lip
commented
Apr 27, 2021
| ]; | ||
|
|
||
| const exampleValidationNames = ['examples', 'example', 'x-example']; | ||
| const exampleValidationNames = ['examples']; |
There was a problem hiding this comment.
http-spec will try to produce examples at all times now, thus there's no need to handle example and x-example separately.
P0lip
commented
Apr 27, 2021
| }; | ||
|
|
||
| const validationFormatters: Record<string, (value: unknown) => ValidationFormat | null> = { | ||
| ['const']: createValidationsFormatter('Allowed'), |
There was a problem hiding this comment.
json-schema-tree turns const into an enum with a single member
|
🎉 This PR is included in version 4.0.0-beta.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by https://github.com/stoplightio/platform-internal/pull/6083
Needs stoplightio/json-schema-tree#8
For stoplightio/elements#1116
See my comments to learn more about the changes.