-
Notifications
You must be signed in to change notification settings - Fork 45
feat: special treatment for top level rows #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caret is now exactly in line with the left side of the component / the row above.
To match Figma design more closely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Didn't have time to check root level use cases beyond the one in demo w array - @philsturgeon over to you to try to verify as many root situations as possible (that they are handled well and are easy to understand as end user). @marcelltoth two small UI things:
|
|
9716518 to
2cc50e0
Compare
That's OK - please leave as semibold, we'll be using Inter in our applications and it is a free font so will document it as the recommended font to pair Elements with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better and works well. I couldn't break it or find any edge case.
|
|
||
| type TypeSelectorProps = ReturnType<typeof useChoices>; | ||
|
|
||
| export const TypeSelector = ({ choices, setSelectedChoice, selectedChoice }: TypeSelectorProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of this component? It is not used anywhere here from what I can see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcelltoth some info on this? @mallachari is right, it doesn't seem to be used at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right. That was an attempt to extract the common selector from SchemaRow and TopLevelSchemaRow but it turned out that the two are different so it didn't make sense to do it in the end. I removed it now, thanks @mallachari for spotting it.
|
🎉 This PR is included in version 4.0.0-beta.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |

Implements stoplightio/elements#1030