Skip to content

Conversation

@mallachari
Copy link

Fixes #119

Removed left margin for top rows so it spans to the edge. That still might require small negative margin in elements to compensate the caret.

Screenshot from 2021-04-07 12-31-00

@mallachari mallachari requested review from a team and P0lip April 7, 2021 10:34
@mallachari mallachari self-assigned this Apr 7, 2021
@mallachari mallachari changed the title chore: ui fixes fix: ui fixes Apr 7, 2021
Copy link
Contributor

@mpodlasin mpodlasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrow and text are misaligned (arrow should be a bit lower here)

Screenshot from 2021-04-07 16-25-53

Property name and type are misaligned (type should be a bit higher)

Screenshot from 2021-04-07 16-25-43

@mallachari
Copy link
Author

Arrow and text are misaligned (arrow should be a bit lower here)

Screenshot from 2021-04-07 16-25-53

Property name and type are misaligned (type should be a bit higher)

Screenshot from 2021-04-07 16-25-43

That arrow thing is included in another issue, not usre about second one, but those should be fairly simple so I can fix it here.

@mpodlasin
Copy link
Contributor

mpodlasin commented Apr 7, 2021

Arrow and text are misaligned (arrow should be a bit lower here)
Screenshot from 2021-04-07 16-25-53
Property name and type are misaligned (type should be a bit higher)
Screenshot from 2021-04-07 16-25-43

That arrow thing is included in another issue, not usre about second one, but those should be fairly simple so I can fix it here.

Ah sorry, I thought that this is the last UI in JSV issue. I am accepting then. Please attempt to fix the name/type issue, but if it's too hard or something, create an issue for it or just add it to that last "UI in JSV" we have.

@mallachari
Copy link
Author

Ah sorry, I thought that this is the last UI in JSV issue. I am accepting then. Please attempt to fix the name/type issue, but if it's too hard or something, create an issue for it or just add it to that last "UI in JSV" we have.

Fixed both :)

@mallachari mallachari merged commit 3c5029e into beta Apr 7, 2021
@mallachari mallachari deleted the chore/ui-fixes branch April 7, 2021 16:06
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batch of JSV UI/UX Fixes

3 participants