Skip to content

Conversation

@mmiask
Copy link
Contributor

@mmiask mmiask commented Apr 1, 2021

A part of fixing: stoplightio/elements#989 - Elements hang with the new JSV on board, if we open a complex model containing multiple $refs and allOfs

This bumps the json-schema-tree that recently bumped json-schema-merge-allof which is fixing that problem (we checked by manually modifying the lockfile to use the latest json-schema-merge-allof)

@mmiask mmiask requested review from a team and billiegoose April 1, 2021 11:09
@mmiask mmiask changed the title chore: bump json-schema-tree to 1.1.2 fix: bump json-schema-tree to 1.1.2 Apr 1, 2021
Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcelltoth
Copy link
Contributor

@P0lip we are investigating whether the included snapshot change was intentional. Can you double check please?

@P0lip
Copy link
Contributor

P0lip commented Apr 1, 2021

I checked it yesterday when I was releasing [email protected], and it's good.
I did side-by-side comparison and didn't notice any UI change.
The reason the snapshots are different is because the $ref handling has improved, and as a result we have more mirror nodes.
Since JSV does not expand mirrored nodes by default, the snapshots have been updated, since we only dump the initial state of component, without any user interaction.
From user perspective, nothing should change, perhaps with the exception that some node might be now collapsed, and they weren't before.
This is not a new behavior, however, as $refs were always supposed to be collapsed by default.

In other words, underlying DOM structure has changed now, because some nodes are no longer existent until a user collapses a row.
BTW If you're in doubt, you can just use a particular schema in storybook and compare it.
I verified all of them, and didn't spot any difference, but I encourage you to do the same, just to double-check.

@marcelltoth
Copy link
Contributor

Amazing, thank you!

@mmiask mmiask merged commit beb54c2 into beta Apr 1, 2021
@mmiask mmiask deleted the chore/bump-json-schema-merge-allof branch April 1, 2021 13:00
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants