Skip to content

feat: drop expanded prop #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: feat: v4 stable release
merged 1 commit into from
Feb 15, 2021
Merged

feat: drop expanded prop #101

merged 1 commit into from
Feb 15, 2021

Conversation

@P0lip
Copy link
Contributor

@P0lip P0lip commented Dec 23, 2020

This is breaking from a component's perspective, but not from ours - we usually set expandedDepth to 1 and do not use expanded anywhere.
Furthemore, migrated a few tests I added yesterday to the other branch.

@P0lip P0lip added the enhancement New feature or request label Dec 23, 2020
@P0lip P0lip self-assigned this Dec 23, 2020
@P0lip P0lip requested a review from a team December 23, 2020 17:17
@P0lip P0lip force-pushed the feat/expanded-prop branch 2 times, most recently from f6420bd to 0fadebb Compare December 23, 2020 21:12
@billiegoose
Copy link
Contributor

we usually set

Inspiring a lot of confidence there @P0lip 😬

@P0lip
Copy link
Contributor Author

P0lip commented Feb 10, 2021

Well, the target branch is beta, thus it's going to be released as beta (3 I think, at least judging by the past releases https://github.com/stoplightio/json-schema-viewer/releases) that nobody uses yet
We can safely merge the PR.

@mallachari
Copy link

Are you willing to use beta in nearby in nearby future or is it for us to play with?
We want to build new jsv design (#103) on beta though need to be sure it can be used.
Btw. we need your acceptance on this pr and any following.

@P0lip
Copy link
Contributor Author

P0lip commented Feb 10, 2021

Are you willing to use beta in nearby in nearby future or is it for us to play with?

Although, there's no plan to use beta in short-term, I assume it's going to be in a reasonable state at all times, meaning we can use it if we need to.

@marcelltoth
Copy link
Contributor

@mallachari I hear your worries. The result of your PR is totally "a reasonable state", if not a perfect one, don't worry about it! 😉

@P0lip P0lip force-pushed the feat/expanded-prop branch from 0fadebb to 6932c2c Compare February 10, 2021 11:10
marcelltoth
marcelltoth approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@marcelltoth marcelltoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, I really don't like redundant props

@P0lip P0lip merged commit 39fd8ba into beta Feb 15, 2021
@P0lip P0lip deleted the feat/expanded-prop branch February 15, 2021 10:26
@philsturgeon philsturgeon mentioned this pull request Jun 21, 2021
Closed
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marcelltoth marcelltoth marcelltoth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@P0lip P0lip

Labels

enhancement New feature or request released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@P0lip @billiegoose @mallachari @marcelltoth @stoplight-bot