fix: errors in middleware do not abort the request

pocket-id · Nov 1, 2024 · 376d747 · 376d747
1 parent 5b9f4d7
commit 376d747
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/backend/internal/middleware/file_size_limit.go b/backend/internal/middleware/file_size_limit.go
@@ -19,6 +19,7 @@ func (m *FileSizeLimitMiddleware) Add(maxSize int64) gin.HandlerFunc {
 		if err := c.Request.ParseMultipartForm(maxSize); err != nil {
 			err = &common.FileTooLargeError{MaxSize: formatFileSize(maxSize)}
 			c.Error(err)
+			c.Abort()
 			return
 		}
 		c.Next()

diff --git a/backend/internal/middleware/jwt_auth.go b/backend/internal/middleware/jwt_auth.go
@@ -29,6 +29,7 @@ func (m *JwtAuthMiddleware) Add(adminOnly bool) gin.HandlerFunc {
 				return
 			} else {
 				c.Error(&common.NotSignedInError{})
+				c.Abort()
 				return
 			}
 		}

diff --git a/backend/internal/middleware/rate_limit.go b/backend/internal/middleware/rate_limit.go
@@ -32,6 +32,7 @@ func (m *RateLimitMiddleware) Add(limit rate.Limit, burst int) gin.HandlerFunc {
 		limiter := getLimiter(ip, limit, burst)
 		if !limiter.Allow() {
 			c.Error(&common.TooManyRequestsError{})
+			c.Abort()
 			return
 		}
-Original file line number
+Diff line change
@@ Expand Up @@
     				return
     			} else {
     				c.Error(&common.NotSignedInError{})
+    				c.Abort()
     				return
     			}
     		}
@@ Expand Down @@