disable grc in global hub.#450
Conversation
morvencao
force-pushed
the
br_disable_grc_in_global_hub
branch
3 times, most recently
from
0228b55 to
55ceafe
Compare
Signed-off-by: morvencao <lcao@redhat.com>
Signed-off-by: morvencao <lcao@redhat.com>
morvencao
force-pushed
the
br_disable_grc_in_global_hub
branch
from
85365ce to
135e486
Compare
morvencao
force-pushed
the
br_disable_grc_in_global_hub
branch
4 times, most recently
from
3fff993 to
37c5b97
Compare
Signed-off-by: morvencao <lcao@redhat.com>
morvencao
force-pushed
the
br_disable_grc_in_global_hub
branch
from
37c5b97 to
4f73abf
Compare
| return mch, grcDisabledByMGH | ||
| } | ||
|
|
||
| func getMCH(ctx context.Context, k8sClient client.Client) (*mchv1.MultiClusterHub, error) { |
There was a problem hiding this comment.
There has a function to getMCH has been implemented before. Maybe we can just keep one of these to the pkg.
There was a problem hiding this comment.
they are not exactly the same.
| func (r *MulticlusterGlobalHubReconciler) reconcileMCH(ctx context.Context, | ||
| mgh *operatorv1alpha2.MulticlusterGlobalHub, | ||
| ) error { | ||
| mch, err := getMCH(ctx, r.Client) |
There was a problem hiding this comment.
if the mch is nil, Is it better to skip the following logic? if so, the e2e will not need to install the fake mch.
Signed-off-by: morvencao <lcao@redhat.com>
|
Kudos, SonarCloud Quality Gate passed! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: morvencao, yanmxa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
3 participants
ref: https://issues.redhat.com/browse/ACM-5632