Use writeAsync

Author: tuliren

action/dist/index.js

@@ -86105,27 +86105,29 @@ const runImageDiffPlugin = (taskId, taskConfig, { ghToken, ghRepository: { repo,
     const filename = (0,external_path_.basename)(taskConfig.image).split('.')[0];
     const imagePath = `${currentDirectory}/${uuid}-image-${filename}.png`;
     core.info(`[${taskId}] Converting image ${taskConfig.image} to ${imagePath}...`);
-    yield dist_default().read(external_fs_default().readFileSync(taskConfig.image), (error, image) => {
-        if (error) {
-            core.error(`[${taskId}] Error reading image: ${error}`);
-            throw error;
-        }
-        image.write(imagePath);
-    });
+    try {
+        const imageFile = yield dist_default().read(taskConfig.image);
+        yield imageFile.writeAsync(imagePath);
+    }
+    catch (error) {
+        core.error(`[${taskId}] Failed to read image ${taskConfig.image}: ${error}`);
+        return;
+    }
     core.info(`[${taskId}] Converted image ${taskConfig.image} to ${imagePath}`);
     const imagePng = png/* PNG.sync.read */.y.sync.read(external_fs_default().readFileSync(imagePath));
     const { width, height } = imagePng;
     core.info(`Image size: ${width} x ${height}`);
     // read baseline and resize
     const baselinePath = `${currentDirectory}/${uuid}-baseline.png`;
     core.info(`[${taskId}] Converting baseline ${taskConfig.baseline} to ${baselinePath}...`);
-    yield dist_default().read(external_fs_default().readFileSync(taskConfig.baseline), (error, image) => {
-        if (error) {
-            core.error(`[${taskId}] Error reading baseline: ${error}`);
-            throw error;
-        }
-        image.resize(width, height).write(baselinePath);
-    });
+    try {
+        const baselineFile = yield dist_default().read(taskConfig.baseline);
+        yield baselineFile.resize(width, height).writeAsync(baselinePath);
+    }
+    catch (error) {
+        core.error(`[${taskId}] Failed to read baseline ${taskConfig.baseline}: ${error}`);
+        return;
+    }
     core.info(`[${taskId}] Converted baseline ${taskConfig.baseline} to ${baselinePath}`);
     const baselinePng = png/* PNG.sync.read */.y.sync.read(external_fs_default().readFileSync(baselinePath));
     // create diff
@@ -86585,8 +86587,9 @@ function run(stoatConfig) {
         else {
             core.info(`Detected pull request number: ${pullRequestNumber}`);
         }
-        core.info(`Fetching repo's SHA (not the build's merge commit SHA)...`);
+        // this is not the build's merge commit SHA
         const repoSha = core.getInput('actual_sha');
+        core.info(`Repo SHA: ${repoSha}`);
         const ghBranch = core.getInput('pr_branch_name');
         yield waitForStoatDevServer(github.context.repo, ghBranch, repoSha);
         core.info('Checking if prior steps succeeded...');

action/dist/index.js.map

@@ -1,11 +1,7 @@
 import Jimp from 'jimp';
 
 (async () => {
-  await Jimp.read('../docs/build/img/logo-128.png', (error, image) => {
-    if (error) {
-      console.error(`Error reading image: ${error}`);
-      throw error;
-    }
-    image.resize(32, 32).write('resize-logo-32.png');
-  });
+  const file = await Jimp.read('../docs/build/img/logo-128.png');
+  await file.writeAsync('resized.png');
+  console.log(`Image size: ${file.getWidth()} x ${file.getHeight()}`);
 })();

action/scripts/testJimp.ts

@@ -35,13 +35,13 @@ const runImageDiffPlugin = async (
   const filename = basename(taskConfig.image).split('.')[0];
   const imagePath = `${currentDirectory}/${uuid}-image-${filename}.png`;
   core.info(`[${taskId}] Converting image ${taskConfig.image} to ${imagePath}...`);
-  await Jimp.read(fs.readFileSync(taskConfig.image), (error, image) => {
-    if (error) {
-      core.error(`[${taskId}] Error reading image: ${error}`);
-      throw error;
-    }
-    image.write(imagePath);
-  });
+  try {
+    const imageFile = await Jimp.read(taskConfig.image);
+    await imageFile.writeAsync(imagePath);
+  } catch (error) {
+    core.error(`[${taskId}] Failed to read image ${taskConfig.image}: ${error}`);
+    return;
+  }
   core.info(`[${taskId}] Converted image ${taskConfig.image} to ${imagePath}`);
   const imagePng = PNG.sync.read(fs.readFileSync(imagePath));
   const { width, height } = imagePng;
@@ -50,13 +50,13 @@ const runImageDiffPlugin = async (
   // read baseline and resize
   const baselinePath = `${currentDirectory}/${uuid}-baseline.png`;
   core.info(`[${taskId}] Converting baseline ${taskConfig.baseline} to ${baselinePath}...`);
-  await Jimp.read(fs.readFileSync(taskConfig.baseline), (error, image) => {
-    if (error) {
-      core.error(`[${taskId}] Error reading baseline: ${error}`);
-      throw error;
-    }
-    image.resize(width, height).write(baselinePath);
-  });
+  try {
+    const baselineFile = await Jimp.read(taskConfig.baseline);
+    await baselineFile.resize(width, height).writeAsync(baselinePath);
+  } catch (error) {
+    core.error(`[${taskId}] Failed to read baseline ${taskConfig.baseline}: ${error}`);
+    return;
+  }
   core.info(`[${taskId}] Converted baseline ${taskConfig.baseline} to ${baselinePath}`);
   const baselinePng = PNG.sync.read(fs.readFileSync(baselinePath));