count_down don't start at init

Author: burrbull

CHANGELOG.md

@@ -9,15 +9,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Added
 
+- `count_down` constructor for `Timer` -> `CountDownTimer` without start [#382]
 - Implementation of RTIC Monotonic for TIM2 & TIM5 under `rtic` feature [#380]
 - `IoPin` for `Output<OpenDrain>> <-> Input<Floating>>` [#374]
 
+[#382]: https://github.com/stm32-rs/stm32f4xx-hal/pull/382
 [#380]: https://github.com/stm32-rs/stm32f4xx-hal/pull/380
 [#374]: https://github.com/stm32-rs/stm32f4xx-hal/pull/374
 
 ### Changed
 
-- [breaking-change] Remove all deprecated
 - [breaking-change] Bump `stm32f4` to 0.14. Update RTIC based examples to use `rtic` 0.6 [#367]
 - [breaking-change] Bump `bxcan` to 0.6 [#371]
 

examples/analog-stopwatch-with-spi-ssd1306.rs

@@ -127,7 +127,8 @@ fn main() -> ! {
     disp.flush().unwrap();
 
     // Create a 1ms periodic interrupt from TIM2
-    let mut timer = Timer::new(dp.TIM2, &clocks).start_count_down(1.hz());
+    let mut timer = Timer::new(dp.TIM2, &clocks).count_down();
+    timer.start(1.hz());
     timer.listen(Event::TimeOut);
 
     free(|cs| {

examples/blinky-timer-irq.rs

@@ -79,7 +79,8 @@ fn main() -> ! {
     cortex_m::interrupt::free(|cs| *G_LED.borrow(cs).borrow_mut() = Some(led));
 
     // Set up a timer expiring after 1s
-    let mut timer = Timer::new(dp.TIM2, &clocks).start_count_down(1.hz());
+    let mut timer = Timer::new(dp.TIM2, &clocks).count_down();
+    timer.start(1.hz());
 
     // Generate an interrupt when the timer expires
     timer.listen(Event::TimeOut);

examples/stopwatch-with-ssd1306-and-interrupts.rs

@@ -93,7 +93,8 @@ fn main() -> ! {
         disp.flush().unwrap();
 
         // Create a 1ms periodic interrupt from TIM2
-        let mut timer = Timer::new(dp.TIM2, &clocks).start_count_down(1.hz());
+        let mut timer = Timer::new(dp.TIM2, &clocks).count_down();
+        timer.start(1.hz());
         timer.listen(Event::TimeOut);
 
         free(|cs| {

examples/timer-periph.rs

@@ -29,7 +29,8 @@ fn main() -> ! {
     let clocks = rcc.cfgr.sysclk(24.mhz()).freeze();
 
     // Create a timer based on SysTick
-    let mut timer = Timer::new(dp.TIM1, &clocks).start_count_down(1.hz());
+    let mut timer = Timer::new(dp.TIM1, &clocks).count_down();
+    timer.start(1.hz());
 
     hprintln!("hello!").unwrap();
     // wait until timer expires

examples/timer-syst.rs

@@ -30,7 +30,8 @@ fn main() -> ! {
     let clocks = rcc.cfgr.sysclk(24.mhz()).freeze();
 
     // Create a timer based on SysTick
-    let mut timer = Timer::syst(cp.SYST, &clocks).start_count_down(24.hz());
+    let mut timer = Timer::syst(cp.SYST, &clocks).count_down();
+    timer.start(24.hz());
 
     hprintln!("hello!").unwrap();
     // wait until timer expires

src/timer.rs

@@ -30,6 +30,14 @@ pub struct CountDownTimer<TIM> {
     clk: Hertz,
 }
 
+impl<TIM> Timer<TIM> {
+    /// Creates CountDownTimer
+    pub fn count_down(self) -> CountDownTimer<TIM> {
+        let Self { tim, clk } = self;
+        CountDownTimer { tim, clk }
+    }
+}
+
 impl<TIM> Timer<TIM>
 where
     CountDownTimer<TIM>: CountDown<Time = Hertz>,
@@ -39,8 +47,7 @@ where
     where
         T: Into<Hertz>,
     {
-        let Self { tim, clk } = self;
-        let mut timer = CountDownTimer { tim, clk };
+        let mut timer = self.count_down();
         timer.start(timeout);
         timer
     }