both embedded-hals for SPI

Author: burrbull

src/gpio/hal_02.rs

@@ -11,7 +11,7 @@ use embedded_hal::digital::v2::{
 };
 
 impl From<PinState> for super::PinState {
-    fn from(state: PinState) -> super::PinState {
+    fn from(state: PinState) -> Self {
         match state {
             PinState::Low => Self::Low,
             PinState::High => Self::High,

src/gpio/hal_1.rs

@@ -11,7 +11,7 @@ use embedded_hal_one::digital::blocking::{
 pub use embedded_hal_one::digital::PinState;
 
 impl From<PinState> for super::PinState {
-    fn from(state: PinState) -> super::PinState {
+    fn from(state: PinState) -> Self {
         match state {
             PinState::Low => Self::Low,
             PinState::High => Self::High,

src/spi.rs

@@ -4,8 +4,36 @@ use core::ptr;
 
 use crate::dma::traits::PeriAddress;
 use crate::gpio::{Const, NoPin, PinA, PushPull, SetAlternate};
-use embedded_hal::spi;
-pub use embedded_hal::spi::{Mode, Phase, Polarity};
+
+/// Clock polarity
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+pub enum Polarity {
+    /// Clock signal low when idle
+    IdleLow,
+    /// Clock signal high when idle
+    IdleHigh,
+}
+
+/// Clock phase
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+pub enum Phase {
+    /// Data in "captured" on the first clock transition
+    CaptureOnFirstTransition,
+    /// Data in "captured" on the second clock transition
+    CaptureOnSecondTransition,
+}
+
+/// SPI mode
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+pub struct Mode {
+    /// Clock polarity
+    pub polarity: Polarity,
+    /// Clock phase
+    pub phase: Phase,
+}
+
+mod hal_02;
+mod hal_1;
 
 use crate::pac::{spi1, RCC, SPI1, SPI2};
 use crate::rcc;
@@ -141,7 +169,7 @@ where
     pub fn new(
         spi: SPI,
         mut pins: PINS,
-        mode: Mode,
+        mode: impl Into<Mode>,
         freq: impl Into<Hertz>,
         clocks: &Clocks,
     ) -> Self {
@@ -155,7 +183,7 @@ where
         pins.set_alt_mode();
 
         Self::_new(spi, pins)
-            .pre_init(mode, freq.into(), SPI::clock(clocks))
+            .pre_init(mode.into(), freq.into(), SPI::clock(clocks))
             .init()
     }
 
@@ -174,7 +202,7 @@ where
     pub fn new_bidi(
         spi: SPI,
         mut pins: PINS,
-        mode: Mode,
+        mode: impl Into<Mode>,
         freq: impl Into<Hertz>,
         clocks: &Clocks,
     ) -> Self {
@@ -188,7 +216,7 @@ where
         pins.set_alt_mode();
 
         Self::_new(spi, pins)
-            .pre_init(mode, freq.into(), SPI::clock(clocks))
+            .pre_init(mode.into(), freq.into(), SPI::clock(clocks))
             .init()
     }
 
@@ -277,7 +305,7 @@ where
     }
 
     /// Pre initializing the SPI bus.
-    pub fn pre_init(self, mode: Mode, freq: Hertz, clock: Hertz) -> Self {
+    fn pre_init(self, mode: Mode, freq: Hertz, clock: Hertz) -> Self {
         // disable SS output
         self.spi.cr2.write(|w| w.ssoe().clear_bit());
 
@@ -493,148 +521,3 @@ where
 
     type MemSize = u8;
 }
-
-impl<SPI, PINS> spi::FullDuplex<u8> for Spi<SPI, PINS, TransferModeNormal>
-where
-    SPI: Instance,
-{
-    type Error = Error;
-
-    fn read(&mut self) -> nb::Result<u8, Error> {
-        self.check_read()
-    }
-
-    fn send(&mut self, byte: u8) -> nb::Result<(), Error> {
-        self.check_send(byte)
-    }
-}
-
-impl<SPI, PINS> spi::FullDuplex<u8> for Spi<SPI, PINS, TransferModeBidi>
-where
-    SPI: Instance,
-{
-    type Error = Error;
-
-    fn read(&mut self) -> nb::Result<u8, Error> {
-        self.spi.cr1.modify(|_, w| w.bidioe().clear_bit());
-        self.check_read()
-    }
-
-    fn send(&mut self, byte: u8) -> nb::Result<(), Error> {
-        self.spi.cr1.modify(|_, w| w.bidioe().set_bit());
-        self.check_send(byte)
-    }
-}
-
-mod blocking {
-    use super::{Error, Instance, Spi, TransferModeBidi, TransferModeNormal};
-    use embedded_hal::blocking::spi::{Operation, Transactional, Transfer, Write, WriteIter};
-    use embedded_hal::spi::FullDuplex;
-
-    impl<SPI, PINS, TRANSFER_MODE> Transfer<u8> for Spi<SPI, PINS, TRANSFER_MODE>
-    where
-        Self: FullDuplex<u8, Error = Error>,
-        SPI: Instance,
-    {
-        type Error = Error;
-
-        fn transfer<'w>(&mut self, words: &'w mut [u8]) -> Result<&'w [u8], Self::Error> {
-            for word in words.iter_mut() {
-                nb::block!(self.send(*word))?;
-                *word = nb::block!(self.read())?;
-            }
-
-            Ok(words)
-        }
-    }
-
-    impl<SPI, PINS> Write<u8> for Spi<SPI, PINS, TransferModeNormal>
-    where
-        Self: FullDuplex<u8, Error = Error>,
-        SPI: Instance,
-    {
-        type Error = Error;
-
-        fn write(&mut self, words: &[u8]) -> Result<(), Self::Error> {
-            for word in words {
-                nb::block!(self.send(*word))?;
-                nb::block!(self.read())?;
-            }
-
-            Ok(())
-        }
-    }
-
-    impl<SPI, PINS> Write<u8> for Spi<SPI, PINS, TransferModeBidi>
-    where
-        Self: FullDuplex<u8, Error = Error>,
-        SPI: Instance,
-    {
-        type Error = Error;
-
-        fn write(&mut self, words: &[u8]) -> Result<(), Self::Error> {
-            for word in words {
-                nb::block!(self.send(*word))?;
-            }
-
-            Ok(())
-        }
-    }
-
-    impl<SPI, PINS> WriteIter<u8> for Spi<SPI, PINS, TransferModeNormal>
-    where
-        Self: FullDuplex<u8, Error = Error>,
-        SPI: Instance,
-    {
-        type Error = Error;
-
-        fn write_iter<WI>(&mut self, words: WI) -> Result<(), Self::Error>
-        where
-            WI: IntoIterator<Item = u8>,
-        {
-            for word in words.into_iter() {
-                nb::block!(self.send(word))?;
-                nb::block!(self.read())?;
-            }
-
-            Ok(())
-        }
-    }
-
-    impl<SPI, PINS> WriteIter<u8> for Spi<SPI, PINS, TransferModeBidi>
-    where
-        Self: FullDuplex<u8, Error = Error>,
-        SPI: Instance,
-    {
-        type Error = Error;
-
-        fn write_iter<WI>(&mut self, words: WI) -> Result<(), Self::Error>
-        where
-            WI: IntoIterator<Item = u8>,
-        {
-            for word in words.into_iter() {
-                nb::block!(self.send(word))?;
-            }
-
-            Ok(())
-        }
-    }
-
-    impl<SPI, PINS, TRANSFER_MODE, W: 'static> Transactional<W> for Spi<SPI, PINS, TRANSFER_MODE>
-    where
-        Self: Write<W, Error = Error> + Transfer<W, Error = Error>,
-    {
-        type Error = Error;
-
-        fn exec<'a>(&mut self, operations: &mut [Operation<'a, W>]) -> Result<(), Error> {
-            for op in operations {
-                match op {
-                    Operation::Write(w) => self.write(w)?,
-                    Operation::Transfer(t) => self.transfer(t).map(|_| ())?,
-                }
-            }
-
-            Ok(())
-        }
-    }
-}