Skip to content

Commit 398a505

Browse files
committed
Add todo's
1 parent 87a52f1 commit 398a505

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

src/gpio.rs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ macro_rules! gpio {
154154
), not(any(
155155
$(feature = $device_except,)*
156156
))))]
157+
// TODO(Sh3Rm4n) Change this to using `variant` when array indexed is implmented via svd2rust.
157158
Gpio::$GPIOX => (*$GPIOX::ptr()).bsrr.write(|w| w.bits(1 << self.i)),
158159
)+
159160
}
@@ -171,6 +172,7 @@ macro_rules! gpio {
171172
), not(any(
172173
$(feature = $device_except,)*
173174
))))]
175+
// TODO(Sh3Rm4n) Change this to using `variant` when array indexed is implmented via svd2rust.
174176
Gpio::$GPIOX => (*$GPIOX::ptr()).bsrr.write(|w| w.bits(1 << (16 + self.i))),
175177
)+
176178
}
@@ -197,6 +199,7 @@ macro_rules! gpio {
197199
), not(any(
198200
$(feature = $device_except,)*
199201
))))]
202+
// TODO(Sh3Rm4n) Change this to using `variant` when array indexed is implmented via svd2rust.
200203
Gpio::$GPIOX => (*$GPIOX::ptr()).idr.read().bits() & (1 << self.i) == 0,
201204
)+
202205
}
@@ -220,6 +223,7 @@ macro_rules! gpio {
220223
), not(any(
221224
$(feature = $device_except,)*
222225
))))]
226+
// TODO(Sh3Rm4n) Change this to using `variant` when array indexed is implmented via svd2rust.
223227
Gpio::$GPIOX => (*$GPIOX::ptr()).odr.read().bits() & (1 << self.i) == 0,
224228
)+
225229
}
@@ -382,13 +386,17 @@ macro_rules! gpio {
382386
impl<MODE> OutputPin for $PXx<Output<MODE>> {
383387
type Error = ();
384388

389+
// TODO
390+
// https://docs.rs/stm32f3/0.9.0/src/stm32f3/stm32f303/gpioa/bsrr.rs.html#1265-1267
385391
fn set_high(&mut self) -> Result<(), Self::Error> {
392+
// TODO(Sh3Rm4n) Change this to using `variant` when array indexed is implmented via svd2rust.
386393
// NOTE(unsafe) atomic write to a stateless register
387394
unsafe { (*$GPIOX::ptr()).bsrr.write(|w| w.bits(1 << self.i)) }
388395
Ok(())
389396
}
390397

391398
fn set_low(&mut self) -> Result<(), Self::Error> {
399+
// TODO(Sh3Rm4n) Change this to using `variant` when array indexed is implmented via svd2rust.
392400
// NOTE(unsafe) atomic write to a stateless register
393401
unsafe { (*$GPIOX::ptr()).bsrr.write(|w| w.bits(1 << (16 + self.i))) }
394402
Ok(())
@@ -404,6 +412,7 @@ macro_rules! gpio {
404412
}
405413

406414
fn is_low(&self) -> Result<bool, Self::Error> {
415+
// TODO(Sh3Rm4n) Change this to using `variant` when array indexed is implmented via svd2rust.
407416
// NOTE(unsafe) atomic read with no side effects
408417
Ok(unsafe { (*$GPIOX::ptr()).idr.read().bits() & (1 << self.i) == 0 })
409418
}
@@ -416,6 +425,7 @@ macro_rules! gpio {
416425
}
417426

418427
fn is_set_low(&self) -> Result<bool, Self::Error> {
428+
// TODO(Sh3Rm4n) Change this to using `variant` when array indexed is implmented via svd2rust.
419429
// NOTE(unsafe) atomic read with no side effects
420430
Ok(unsafe { (*$GPIOX::ptr()).odr.read().bits() & (1 << self.i) == 0 })
421431
}

0 commit comments

Comments
 (0)