Skip to content

Commit 740c1c1

Browse files
committed
address comments kubernetes#2, remove trailing whitespaces
1 parent 39d4ecf commit 740c1c1

File tree

2 files changed

+21
-15
lines changed

2 files changed

+21
-15
lines changed

keps/sig-auth/3926-handling-undecryptable-resources/README.md

+15-8
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ tags, and then generate with `hack/update-toc.sh`.
8585
- [Proposal](#proposal)
8686
- [User Stories (Optional)](#user-stories-optional)
8787
- [Story 1](#story-1)
88+
- [Story 2](#story-2)
8889
- [Notes/Constraints/Caveats (Optional)](#notesconstraintscaveats-optional)
8990
- [Risks and Mitigations](#risks-and-mitigations)
9091
- [Design Details](#design-details)
@@ -136,10 +137,10 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
136137
- [ ] (R) Design details are appropriately documented
137138
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
138139
- [ ] e2e Tests for all Beta API Operations (endpoints)
139-
- [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
140+
- [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
140141
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
141142
- [ ] (R) Graduation criteria is in place
142-
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
143+
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
143144
- [ ] (R) Production readiness review completed
144145
- [ ] (R) Production readiness review approved
145146
- [ ] "Implementation History" section is up-to-date for milestone
@@ -175,8 +176,8 @@ updates.
175176
176177
[documentation style guide]: https://github.com/kubernetes/community/blob/master/contributors/guide/style-guide.md
177178
-->
178-
Encryption at rest has been a stable Kubernetes for a long time. Every now and
179-
then there had been cases where, be it by improper handling or external system
179+
Encryption at rest for API resources has been a stable part of Kubernetes for a long time.
180+
Every now and then there had been cases where, be it by improper handling or external system
180181
failures, the cluster encryption got into a broken state.
181182

182183
If a single object of a resource type cannot be decrypted, listing resources of that
@@ -254,6 +255,12 @@ with it. I know that these will either be recreated by a controller, or I can
254255
manually recreate them. I would like a simple way to figure out which resources
255256
fail decryption and I would like a way to remove them via Kubernetes API.
256257

258+
#### Story 2
259+
260+
I would like to remove a namespace I no longer need. However, some of the resources
261+
inside of the namespace were encrypted before the encryption at
262+
rest configuration broke, which blocks a successful namespace delete.
263+
257264
### Notes/Constraints/Caveats (Optional)
258265

259266
<!--
@@ -323,7 +330,7 @@ a new status should be introduced - `StatusReasonStoreReadError`.
323330
// Details:
324331
// "kind" string - the kind attribute of the resource being acted on.
325332
// "name" string - the prefix where the reading error(s) occurred
326-
// "causes" []StatusCause
333+
// "causes" []StatusCause
327334
// - (optional):
328335
// - "type" CauseType - CauseTypeUnexpectedServerResponse
329336
// - "message" string - the error message from the store backend
@@ -710,10 +717,10 @@ Recall that end users cannot usually observe component logs or access metrics.
710717
-->
711718

712719
- [ ] Events
713-
- Event Reason:
720+
- Event Reason:
714721
- [ ] API .status
715-
- Condition name:
716-
- Other field:
722+
- Condition name:
723+
- Other field:
717724
- [ ] Other (treat as last resort)
718725
- Details:
719726

keps/sig-auth/3926-handling-undecryptable-resources/kep.yaml

+6-7
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,18 @@
11
title: Handling undecryptable resources
22
kep-number: 3926
33
authors:
4-
- "@jane.doe"
4+
- "@stlaz"
55
owning-sig: sig-auth
66
participating-sigs:
77
- sig-auth
88
- sig-api
99
status: provisional
1010
creation-date: 2023-03-27
1111
reviewers:
12-
- TBD
13-
- "@alice.doe"
12+
- "@liggit"
13+
- "@deads2k"
1414
approvers:
1515
- TBD
16-
- "@oscar.doe"
1716

1817
see-also:
1918
-
@@ -30,9 +29,9 @@ latest-milestone: "v1.28"
3029

3130
# The milestone at which this feature was, or is targeted to be, at each stage.
3231
milestone:
33-
alpha: "v1.28"
34-
beta: "v1.29"
35-
stable: "v1.30"
32+
alpha: "v1.29"
33+
beta: "v1.30"
34+
stable: "v1.31"
3635

3736
# The following PRR answers are required at alpha release
3837
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)