fix(publish): channel is Buffer for messageBuffer event (#1206)

fixes #1205

Author: erictheswift

src/commands-utils/emitMessage.js

@@ -1,18 +1,12 @@
 export default function emitMessage(redisMock, channel, message, pattern) {
   process.nextTick(() => {
+    const [patternEvent, regularEvent, channelToEmit] = Buffer.isBuffer(message)
+      ? ['pmessageBuffer', 'messageBuffer', Buffer.from(channel)]
+      : ['pmessage', 'message', channel]
     if (pattern) {
-      redisMock.emit(
-        Buffer.isBuffer(message) ? 'pmessageBuffer' : 'pmessage',
-        pattern,
-        channel,
-        message
-      )
+      redisMock.emit(patternEvent, pattern, channelToEmit, message)
     } else {
-      redisMock.emit(
-        Buffer.isBuffer(message) ? 'messageBuffer' : 'message',
-        channel,
-        message
-      )
+      redisMock.emit(regularEvent, channelToEmit, message)
     }
   })
 }

test/integration/commands/publish.js

@@ -39,7 +39,7 @@ runTwinSuite('publish', command => {
       const redis2 = new Redis()
       const buffer = Buffer.alloc(8)
       redisPubSub.on('messageBuffer', (channel, message) => {
-        expect(channel).toBe('emails')
+        expect(channel).toEqual(Buffer.from('emails'))
         expect(message).toBe(buffer)
         redisPubSub.unsubscribe('emails')
         done()
@@ -77,7 +77,7 @@ runTwinSuite('publish', command => {
       const buffer = Buffer.alloc(0)
       redisPubSub.on('pmessageBuffer', (pattern, channel, message) => {
         expect(pattern).toBe('emails.*')
-        expect(channel).toBe('emails.urgent')
+        expect(channel).toEqual(Buffer.from('emails.urgent'))
         expect(message).toBe(buffer)
         redisPubSub.punsubscribe('emails.*')
         done()