Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md_summary prints null instead of default values. #128

Open
alinelena opened this issue May 3, 2024 · 2 comments
Open

md_summary prints null instead of default values. #128

alinelena opened this issue May 3, 2024 · 2 comments
Labels
enhancement New/improved feature or request

Comments

@alinelena
Copy link
Member

  timestep: 1.0
  traj_append: false
  traj_every: 100
  traj_file: null
  restart_stem: null
  restarts_to_keep: 4
  rotate_restart: true
  seed: null
  ensemble: npt
  equil_steps: 0
  file_prefix: null
@ElliottKasoar ElliottKasoar added janus enhancement New/improved feature or request labels May 8, 2024
@ElliottKasoar
Copy link
Member

ElliottKasoar commented May 8, 2024

My initial thought was that things like file_prefix are not readily accessible, as it's not even a simple default value, but actually we can access all of the attributes of the ensemble when we create the summary, just before we call .run, so this shouldn't be too bad to fix.

Only issue is that it depends if we consider the summary to be from the CLI perspective (it doesn't set these) or the Python perspective.

It's not possible at the moment, but if, for example, we wanted to use the summary as a new config for a different structure (so overwrite the structure only), we may want to keep file_prefix as None, rather than using the file_prefix that's been created for the first structure.

@ElliottKasoar
Copy link
Member

ElliottKasoar commented Oct 18, 2024

Maybe what we should have is

  • inputs

    • All CLI options that you could take and use directly as a --config
    • I still think this should probably be the CLI input/default, rather than anything that is inferred in the Python
    • We could even allow it to be read directly from summaries
  • info

    • Extra details e.g. formula, n_atoms, start/end time etc.)
  • Maybe also outputs?

    • Files created
    • Slightly trickier in the case of optional minimization etc.

The first two would basically be rearranging what we already have, so maybe worth doing on their own, then outputs might be nice as an alternative to outputting the inferred file_prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New/improved feature or request
Projects
None yet
Development

No branches or pull requests

2 participants