Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEMO Reproducibility issues #2787

Open
sergisiso opened this issue Nov 17, 2024 · 2 comments
Open

NEMO Reproducibility issues #2787

sergisiso opened this issue Nov 17, 2024 · 2 comments

Comments

@sergisiso
Copy link
Collaborator

sergisiso commented Nov 17, 2024

We can now run NEMOv5 with full numerical reproducibility if conservative flags are used. However, this is not the case for NEMOv4. We should identify the exact file-routine-loop that causes these divergences to exclude them and track the issues.

@sergisiso
Copy link
Collaborator Author

Also, I have found that different compilers with different behaviour (also for NEMOv5), so I think we will need to test them all (at least for CPUs), which will increase the integration test time. But to compensate maybe could make the passthrough step an optional action because the threaded transformation already contains the passthrough check implicitly. Then when a threaded compiler check fails we would have the possibility to manually trigger the passthrough action to see if it was a frontend issue or a transformation issue. What do you think @arporter ?

@sergisiso sergisiso changed the title NEMOv4 Reproducibility issues NEMO Reproducibility issues Nov 20, 2024
@arporter
Copy link
Member

Having the option to trigger different tests only when required sounds good to me. We could potentially have them run on a different machine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants