Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LFRic] [PSyAD] Adjoint tests do not split element order #2779

Open
DrTVockerodtMO opened this issue Nov 14, 2024 · 0 comments
Open

[LFRic] [PSyAD] Adjoint tests do not split element order #2779

DrTVockerodtMO opened this issue Nov 14, 2024 · 0 comments

Comments

@DrTVockerodtMO
Copy link
Collaborator

Once LFRic 4443 is merged, the get_fs will take in a horizontal and vertical element order instead of just the element_order namelist variable. This is not expected to be merged before LFRic vn2.1 so this does not need to be addressed for PSyclone 3.0, but does need to be addressed.

The adjoint tests use the get_fs method. These method calls and the validation testing them will need to be changed to incorporate this new format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant