Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionReq to_string does not retain patch in output #116

Closed
frewsxcv opened this issue Jun 25, 2017 · 3 comments
Closed

VersionReq to_string does not retain patch in output #116

frewsxcv opened this issue Jun 25, 2017 · 3 comments

Comments

@frewsxcv
Copy link
Contributor

Found this while fuzzing this crate.

extern crate semver;

fn main() {
    let str_input = "8.*.7";
    println!("input:\n\t{:?}", str_input);

    let parsed1 = semver::VersionReq::parse(str_input).unwrap();
    println!("parsed:\n\t{:?}", parsed1);

    let version_req_s = parsed1.to_string();
    println!("parsed to_string:\n\t{:?}", version_req_s);

    let parsed2 = semver::VersionReq::parse(&version_req_s).unwrap();
    println!("parsed to_string parsed:\n\t{:?}", parsed2);
}
input:
	"8.*.7"
parsed:
	VersionReq { predicates: [Predicate { op: Wildcard(Minor), major: 8, minor: None, patch: Some(7), pre: [] }] }
parsed to_string:
	"8.*"
parsed to_string parsed:
	VersionReq { predicates: [Predicate { op: Wildcard(Minor), major: 8, minor: None, patch: None, pre: [] }] }
@frewsxcv frewsxcv changed the title VersionReq to_string does not retain patch in ouput VersionReq to_string does not retain patch in output Jun 25, 2017
@steveklabnik
Copy link
Contributor

Soooooo I thought that this was just malformed in general....

@dtolnay
Copy link
Owner

dtolnay commented May 17, 2021

Relevant issue for rejecting 8.*.7 upstream in semver-parser: steveklabnik/semver-parser#62

@dtolnay
Copy link
Owner

dtolnay commented May 25, 2021

Fixed in 1.0.0.

fn main() {
    println!("{}", semver::VersionReq::parse("8.*.7").unwrap_err());
}
unexpected character after wildcard in version req

@dtolnay dtolnay closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants