Merge pull request #47 from swrobel/does-not-contain

Add does_not_contain matcher

Author: stevehodgkiss

README.md

@@ -16,7 +16,7 @@ Spec (files in `spec/lib/generators` are recognized as generator type example gr
 
 ```ruby
 # spec/lib/generators/test/test_generator_spec.rb
-    
+
 require "generator_spec"
 
 describe TestGenerator, type: :generator do
@@ -33,13 +33,13 @@ describe TestGenerator, type: :generator do
   end
 end
 ```
-    
+
 An RSpec file matching DSL is also provided, taken with permission from [beard](https://github.com/carlhuda/beard/blob/master/spec/support/matcher.rb) by [carlhuda](https://github.com/carlhuda).
 
 ```ruby
 describe TestGenerator, "using custom matcher", type: :generator do
   destination File.expand_path("../../tmp", __FILE__)
-  
+
   before do
     prepare_destination
     run_generator
@@ -52,6 +52,7 @@ describe TestGenerator, "using custom matcher", type: :generator do
         directory "initializers" do
           file "test.rb" do
             contains "# Initializer"
+            does_not_contain "Something else"
           end
         end
       end
@@ -60,6 +61,7 @@ describe TestGenerator, "using custom matcher", type: :generator do
           file "123_create_tests.rb"
           migration "create_tests" do
             contains "class TestMigration"
+            does_not_contain "Something else"
           end
         end
       end

lib/generator_spec/matcher.rb

@@ -12,6 +12,7 @@ def description
       def initialize(name, &block)
         @contents = []
         @name = name
+        @negative_contents = []
 
         if block_given?
           instance_eval(&block)
@@ -22,6 +23,10 @@ def contains(text)
         @contents << text
       end
 
+      def does_not_contain(text)
+        @negative_contents << text
+      end
+
       def matches?(root)
         unless root.join(@name).exist?
           throw :failure, root.join(@name)
@@ -40,6 +45,12 @@ def check_contents(file)
             throw :failure, [file, string, contents]
           end
         end
+
+        @negative_contents.each do |string|
+          if contents.include?(string)
+            throw :failure, [:not, file, string, contents]
+          end
+        end
       end
     end
 
@@ -129,7 +140,11 @@ def description
 
       def failure_message
         if @failure.is_a?(Array) && @failure[0] == :not
-          "Structure should not have had #{@failure[1]}, but it did"
+          if @failure.length > 2
+            "Structure should have #{@failure[1]} without #{@failure[2]}. It had:\n#{@failure[3]}"
+          else
+            "Structure should not have had #{@failure[1]}, but it did"
+          end
         elsif @failure.is_a?(Array)
           "Structure should have #{@failure[0]} with #{@failure[1]}. It had:\n#{@failure[2]}"
         else

spec/generator_spec/matcher_spec.rb

@@ -107,6 +107,26 @@ module Matcher
             }.to throw_symbol(:failure)
           end
         end
+
+        context 'with does_not_contain' do
+          before do
+            write_file(location, 'class CreatePosts')
+          end
+
+          it 'doesnt throw if the contents dont include the string' do
+            file.does_not_contain 'PostsMigration'
+            expect {
+              file.matches?(TMP_ROOT)
+            }.to_not throw_symbol
+          end
+
+          it 'throws :failure if the contents include the string' do
+            file.does_not_contain 'CreatePosts'
+            expect {
+              file.matches?(TMP_ROOT)
+            }.to throw_symbol(:failure)
+          end
+        end
       end
     end
 
@@ -153,6 +173,26 @@ module Matcher
             }.to throw_symbol(:failure)
           end
         end
+
+        context 'with does_not_contain' do
+          before do
+            write_file(location, 'class CreatePosts')
+          end
+
+          it 'doesnt throw if the migration doesnt include the given content' do
+            migration.does_not_contain('CreateNotes')
+            expect {
+              migration.matches?(TMP_ROOT)
+            }.to_not throw_symbol
+          end
+
+          it 'throws failure if the migration includes the given content' do
+            migration.does_not_contain('CreatePosts')
+            expect {
+              migration.matches?(TMP_ROOT)
+            }.to throw_symbol(:failure)
+          end
+        end
       end
     end