-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Data for historical exchange rate for BTN #21
Comments
Hi, thanks for letting me know (and glad you like the package!) Just before I look into this, can I double-check that we are looking at the right currency code (some are very similar, and can therefore cause understandable confusion). library(priceR)
library(tidyverse)
currencies() %>%
filter(code %>% substr(1,2) == "BT")
# description code
# 1 Bitcoin BTC
# 2 Bhutanese Ngultrum BTN That is, I suspect this is what you're after? options(scipen = 999)
bitcoin <- historical_exchange_rates("SGD", to = "BTC",
start_date = "2010-01-01", end_date = "2020-06-30")
bitcoin %>% tail
date one_SGD_equivalent_to_x_BTC
3829 2020-06-25 0.000078
3830 2020-06-26 0.000078
3831 2020-06-27 0.000080
3832 2020-06-28 0.000079
3833 2020-06-29 0.000078
3834 2020-06-30 0.000079 If there's still an issue, let me know and I'll look into it. |
Hi Steve! Thanks for the reply! I am actually looking at Bhutanese Ngultrum. I have pasted my source code here, and I actually see this in ggplot.
So after plotting on ggplot, this is what I have seen. It is the same for BTN/USD pair as well. Looking forward to hear from you! |
I am also seeing the same thing for IDR/SGD, THB/SGD, MYR/SGD and TWD/SGD pairs as well before 30/11/2003. I checked with the ECB Currency Converter and it gave correct results. |
I see it now in historical_exchange_rates("BTN", to = "SGD", start_date = "2020-04-28",
end_date = "2020-05-03")
# date one_BTN_equivalent_to_x_SGD
# 1 2020-04-28 1.537000
# 2 2020-04-29 1.534500
# 3 2020-04-30 1.533800
# 4 2020-05-01 0.018711
# 5 2020-05-02 0.018855
# 6 2020-05-03 0.018855 And with historical_exchange_rates("BTN", to = "TBH", start_date = "2020-04-28",
end_date = "2020-05-03")
date one_BTN_equivalent_to_x_TBH
1 2020-04-28 3.973800
2 2020-04-29 3.976100
3 2020-04-30 3.993200
4 2020-05-01 0.048693
5 2020-05-02 0.048930
6 2020-05-03 0.048930 Have you noticed anything regarding currency pairs that don't include Thanks for reporting. I will report upstream. |
Thanks! It is awesome! Yeah. As I indicated in one of the post, IDR/SGD, THB/SGD, MYR/SGD and TWD/SGD pairs are a bit weird before 30/11/2003. |
Hi,
I have just started using your package to get historical FX data. I must say the package is awesome, rather than an exhausting scraping of online pages to get all the FX.
On the other hand, I am trying to get exchange rates for BTN/USD and BTN/SGD pairing. However, it seems that the data doesn't seem correct. BTN/SGD has an exchange rate way lower than 0.001, but it is shown as above 1 until 10/5/2020 when it is shown as 1 the correct values. I couldn't verify at the ECB Currency Converter though.
May I know what could be the cause?
Thank you very much in advance!
The text was updated successfully, but these errors were encountered: