Skip to content
This repository was archived by the owner on Aug 27, 2023. It is now read-only.

Commit fd6b8f3

Browse files
author
Pavel Pulec
committed
Do not search for releases when fallback disallowed
The fuction "request.locator.get_releases" looking for releases in an upstream was called regardless of permissions that were set on a given package. Looking for releases of packages in the upstream that were disallowed by the "pypi.disallow_fallback" option exposed the names of disallowed packages to the upstream. This is unsolicited behavior. This change also fixes these warnings that were logged for all disallowed packages: WARNING [pypicloud.locator] Error fetching 'package1' from upstream: 404 Client Error: Not Found for url: https://pypi.org/pypi/package1/json Fixed issue #327
1 parent 50710be commit fd6b8f3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pypicloud/views/simple.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,10 @@ def package_versions_json(context, request):
161161

162162
def get_fallback_packages(request, package_name, redirect=True):
163163
"""Get all package versions for a package from the fallback_base_url"""
164-
releases = request.locator.get_releases(package_name)
165164
pkgs = {}
166165
if not request.access.has_permission(package_name, "fallback"):
167166
return pkgs
167+
releases = request.locator.get_releases(package_name)
168168
for release in releases:
169169
url = release["url"]
170170
filename = posixpath.basename(url)

0 commit comments

Comments
 (0)