Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can ros wrapper using svo file publish svo recorded time? #411

Closed
ZhenghaoFei opened this issue Apr 14, 2019 · 4 comments · May be fixed by #763
Closed

Can ros wrapper using svo file publish svo recorded time? #411

ZhenghaoFei opened this issue Apr 14, 2019 · 4 comments · May be fixed by #763
Assignees
Labels
closed_for_stale Issue closed for inactivity Stale

Comments

@ZhenghaoFei
Copy link

Hi,

Is there any proper way to let ros wrapper running with svo file to publish svo record timestamp than the current system timestamp?
I tried to modified all t = ros::Time::now() in mSvoMode to sl_tools::slTime2Ros(mZed.getTimestamp(sl::TIME_REFERENCE_CURRENT)) and it seems work. But I am not sure if this change will break other parts.

Thanks,

@Myzhar Myzhar self-assigned this Apr 15, 2019
@Myzhar
Copy link
Member

Myzhar commented Apr 15, 2019

This is a good question.

I tried to solve this problem a few months ago, but I have not found a good solution.
What you are saying is correct if only the ZED node is running, but ROS is an ecosystem and the time should be coherent for each running node.

The good way to work should be to create a ROS clock server and to publish the ZED timestamp as /clock message, so any other node can use it as simulation time: http://wiki.ros.org/Clock

Here comes the problem: the ZED wrapper is a nodelet and only when the nodelet starts we can start the clock server, but to start the nodelet we need a nodelet server which requires a /clock message to start. It's a snake biting his tail...

There is an open question on ROS answers about this problem, but no reply has come:
https://answers.ros.org/question/301128/clock-server-as-nodelet/

@ZhenghaoFei
Copy link
Author

Thank you Myzhar for your quick reply! Yes, it is a snake biting his tail problem with the current ROS nodelet...
Should I close this issue or you prefer to keep it as an open feature request?

@Myzhar
Copy link
Member

Myzhar commented Apr 15, 2019

Do not close it. It's a reminder 👍

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added Stale closed_for_stale Issue closed for inactivity labels Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed_for_stale Issue closed for inactivity Stale
Development

Successfully merging a pull request may close this issue.

2 participants