Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .distignore #36

Closed
westonruter opened this issue Aug 2, 2017 · 3 comments
Closed

Add support for .distignore #36

westonruter opened this issue Aug 2, 2017 · 3 comments

Comments

@westonruter
Copy link

WP-CLI supports a .distignore file which is intended to be used in the release process. See https://github.com/wp-cli/scaffold-command/blob/master/templates/plugin-distignore.mustache

It would be be handy if grunt-wp-deploy could read from these files when building the file list, if for example a build directory was not supplied in the Gruntfile.

@johnbillion
Copy link
Contributor

There's also a .gitattributes file that's commonly used to ignore files from a package.

@johnbillion
Copy link
Contributor

johnbillion commented Feb 6, 2019

I don't think file ignorance should be the responsibility of this package. The build process should take care of copying the desired files into the build directory.

I'm using the gitattributes-globs package from NPM to automatically ignore files in my .gitignore file, I'm pretty sure it works for the .distignore syntax too.

https://github.com/johnbillion/user-switching/blob/e64483b929f0add59c4c9e8f333ac27753db140c/Gruntfile.js#L7-L9

@stephenharris
Copy link
Owner

Sorry, I missed this ticket when originally posted. I'm inclined to agree with John here, this package was only intended to be a wrapper for SVN to make deploying a finished build to WP.org easier. The build folder should be the finished artifact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants