-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to include generated type registry in exports #1067
Comments
Hi @oliveryasuna ; just checking, but what do you mean by isolated builds? Initially I would have guessed that we should just have |
@stephenh Honestly, I have no idea what I meant by "isolated builds" when I wrote that late last night. Maybe I meant that the generated TS files could be in their own package, and some developers will write their own type registry instead of using the generated one. Therefore, by adding the type registry to the the exports by default, it could introduce namespace conflicts, hence could be viewed as a breaking change. |
Ah yeah; you're right that it's a change in behavior, but dunno, personally I don't think a new symbol being exported from So, given that, are you fine with updating your PR to not introduce a new Thanks! |
@stephenh Either perspective is valid. My concern is an edge edge edge case. Yes, I will update my PR! |
With
outputIndex=true
andoutputTypeRegistry=true
, the generatedindex.ts
does not exporttypeRegistry.ts
.It would not make sense to make it export by default because that could break isolated builds. I think a new option would be useful, and perhaps make it default in the next major release. Happy to contribute.
The text was updated successfully, but these errors were encountered: