Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.0 breaks semver, should be 2.0.0 #289

Closed
ahill-mlft opened this issue May 16, 2018 · 7 comments
Closed

1.6.0 breaks semver, should be 2.0.0 #289

ahill-mlft opened this issue May 16, 2018 · 7 comments

Comments

@ahill-mlft
Copy link

The backward compatibility issues in the changelog, especially the removal of public APIs, are pretty clear signals the major version should have been bumped. For example, the removal of the MessageStatic trait breaks the Prometheus crate currently on crates.io.

@stepancheg
Copy link
Owner

Probably you are right. Is there anything can be done now?

@ahill-mlft
Copy link
Author

There is! You can yank version 1.6.0, then republish it as 2.0.0.

@stepancheg
Copy link
Owner

That will break crates which depend on 1.6, not sure it’s right thing now.

As a temporary solution I can suggest to explicitly depend on ~1.5 in your crates now.

Sorry again.

@bachp
Copy link

bachp commented May 16, 2018

One solution would be to re-publish 1.5 as 1.7
And then re-release 1.6 as 2.0

@pamolloy
Copy link

@stepancheg @bachp's solution is a good one. Please follow that recommendation.

Like any bug when writing software, bumping a semver incorrectly happens, but it is important to fix it just like any other bug.

@stepancheg
Copy link
Owner

OK, republished version 1.7.1 from 1.5 branch. Not sure it's the best idea, but OK.

@stepancheg
Copy link
Owner

Republished 1.6 branch as 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants