-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.6.0 breaks semver, should be 2.0.0 #289
Comments
Probably you are right. Is there anything can be done now? |
There is! You can yank version 1.6.0, then republish it as 2.0.0. |
That will break crates which depend on 1.6, not sure it’s right thing now. As a temporary solution I can suggest to explicitly depend on ~1.5 in your crates now. Sorry again. |
One solution would be to re-publish 1.5 as 1.7 |
@stepancheg @bachp's solution is a good one. Please follow that recommendation. Like any bug when writing software, bumping a semver incorrectly happens, but it is important to fix it just like any other bug. |
OK, republished version 1.7.1 from 1.5 branch. Not sure it's the best idea, but OK. |
Republished 1.6 branch as 2.0.0. |
The backward compatibility issues in the changelog, especially the removal of public APIs, are pretty clear signals the major version should have been bumped. For example, the removal of the
MessageStatic
trait breaks the Prometheus crate currently on crates.io.The text was updated successfully, but these errors were encountered: