Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning BiocCheck(); linting revision; GHA bump to Bioc devel #83

Merged
merged 8 commits into from
Aug 21, 2023

Conversation

HelenaLC
Copy link
Contributor

BiocCheck-related changes

  • dropped LazyData: in the DESCRIPTION as advised by Bioc; example data is now loaded explicitly on demand
  • implemented Bioc code guidelines as outlined here, e.g.:
    • fixed indentation and consistent spacing (e.g., after , and logical operators, not after = etc.)
    • fixed SCE data handling with corresponding accessors (instead of @)
    • keeping to an 80-character line limit when sensible

other updates

  • rewrote code to rid of various deprecated functions (e.g., magrittr::not, purrr::when)
  • various code simplifications, e.g., use of base R instead of tidy-syntax when sensible
  • removed unused image files and move plotly example PNG to inst/extdata
  • updated GHA to use Bioconductor devel

@stemangiola stemangiola self-requested a review August 21, 2023 10:01
@stemangiola stemangiola added the enhancement New feature or request label Aug 21, 2023
@stemangiola stemangiola merged commit 797cf25 into stemangiola:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Achieve ~clean BiocCheck() for tidySingleCellExperiment
3 participants