Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summarize as an explicit alias of the function summarise #67

Merged
merged 9 commits into from
Jun 19, 2023
Merged

Add summarize as an explicit alias of the function summarise #67

merged 9 commits into from
Jun 19, 2023

Conversation

william-hutchison
Copy link
Collaborator

This pull request adds summarize as an explicit alias of the function summarise. This change increases consistency between tidySingleCellExperiment and dplyr.

Copy link
Owner

@stemangiola stemangiola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the version should be 1.10.0
  • you should have a unit test almost every time you change or add something
  • We have some conflicts apparently

@william-hutchison
Copy link
Collaborator Author

william-hutchison commented Jun 19, 2023

Thanks for letting me know. I have added a test for the summarize alias and manually resolved the conflict. It was caused by us both updating the version number. I have now set the version number to 1.12.0, upgrading from 1.11.1.

Copy link
Owner

@stemangiola stemangiola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Sorry, the version should be 1.11.2

  • also, ask to "review" only after at least one github action has passed green.

@stemangiola
Copy link
Owner

stemangiola commented Jun 19, 2023

Error: object ‘aggregate_cells’ is not exported by 'namespace:ttservice'

@william-hutchison I think you have to force the service version in DESCRIPTION like it is in tidyseurat

@stemangiola stemangiola self-requested a review June 19, 2023 07:37
Copy link
Owner

@stemangiola stemangiola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@stemangiola stemangiola merged commit 1cce7e5 into stemangiola:master Jun 19, 2023
@william-hutchison
Copy link
Collaborator Author

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding summarize.SingleCellExperiment as an explicit alias of summarise.SingleCellExperiment
2 participants