-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add summarize
as an explicit alias of the function summarise
#67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the version should be 1.10.0
- you should have a unit test almost every time you change or add something
- We have some conflicts apparently
Thanks for letting me know. I have added a test for the summarize alias and manually resolved the conflict. It was caused by us both updating the version number. I have now set the version number to 1.12.0, upgrading from 1.11.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Sorry, the version should be 1.11.2
-
also, ask to "review" only after at least one github action has passed green.
@william-hutchison I think you have to force the service version in DESCRIPTION like it is in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done!
Thanks for your help! |
This pull request adds
summarize
as an explicit alias of the functionsummarise
. This change increases consistency between tidySingleCellExperiment and dplyr.