Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aggregate cells function and dependencies #57

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Added aggregate cells function and dependencies #57

merged 2 commits into from
Mar 6, 2023

Conversation

william-hutchison
Copy link
Collaborator

This pull request adds the function aggregate_cells() to the methods file. This addition required multiple functions from the tidybulk package, which I placed in tibybulk_utilities.R. Two further helper functions were required, which I placed in utilities.R.

@william-hutchison william-hutchison linked an issue Mar 6, 2023 that may be closed by this pull request
@william-hutchison william-hutchison marked this pull request as draft March 6, 2023 00:46
NAMESPACE Outdated Show resolved Hide resolved
@stemangiola
Copy link
Owner

Also, please have a look to the failing tests.

R/tidybulk_utilities.R Outdated Show resolved Hide resolved
@william-hutchison william-hutchison marked this pull request as ready for review March 6, 2023 02:49
@stemangiola stemangiola merged commit d348bed into stemangiola:master Mar 6, 2023
@stemangiola
Copy link
Owner

@william-hutchison congrats! you are now a contributor.

@mikelove
Copy link

mikelove commented Mar 6, 2023

Fantastic. Very useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add aggregate_cells
3 participants