Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt aggregate_features() to tidyseurat which is based on ttservice #63

Closed
stemangiola opened this issue Jun 7, 2023 · 3 comments · Fixed by #64
Closed

adapt aggregate_features() to tidyseurat which is based on ttservice #63

stemangiola opened this issue Jun 7, 2023 · 3 comments · Fixed by #64
Assignees
@william-hutchison

Comments

@stemangiola
Copy link
Owner

@william-hutchison aggregate_cells() in tidyseurat relies on the generic method in ttservice, could you please adapt this method to tidyseurat, so they can be used together if both tidyseurat and tidySCE are loaded at the same time?

stemangiola/tidyseurat#61

It is just few lines of code to be modified in the methods
@stemangiola
Copy link
Owner Author

Hello @william-hutchison would you have time today to make this pull request?

@william-hutchison
Copy link
Collaborator

Hi @stemangiola, sure I will start working on this now

@stemangiola
Copy link
Owner Author

@william-hutchison for reference, When you are doing a pull request related to an issue you should link them with the menu on the right.

@stemangiola stemangiola linked a pull request Jun 19, 2023 that will close this issue
Use generic aggregate cells from ttservice #64
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@william-hutchison william-hutchison

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use generic aggregate cells from ttservice
2 participants
@stemangiola @william-hutchison