Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Protocol 20 community SDK issues with new XDR/API changes #1009

Closed
Shaptic opened this issue Oct 5, 2023 · 1 comment
Closed
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Oct 5, 2023

Once the XDR and API are stabilized, we will need to inform the community SDK maintainers about the changes.

The CLI script can add comments rather than open new issues, but a new issue is better given that many SDK repos have already closed the Protocol 20 issues (e.g. Soneso/stellar_flutter_sdk#73).

Summary of Changes

XDR

The XDR needs to be updated to stellar/stellar-xdr@6a620d1. This includes a non-trivial list of breaking changes (mostly renames):

  • The BumpFootprintExpirationOp is now ExtendFootprintTTLOp and its ledgersToExpire field is now named extendTo, but it serves the same purpose.
  • ContractExecutable.contractExecutableToken is now contractExecutableStellarAsset
  • SorobanTransactionData.refundableFee is now resourceFee
  • This new fee encompasses the entirety of the Soroban-related resource fees. Note that this is distinct from the "network-inclusion" fee that you would set on your transaction
  • see Upgrade XDR to the final, stable testnet version. js-stellar-base#704 for an example migration

RPC

@Shaptic Shaptic added the documentation Improvements or additions to documentation label Oct 5, 2023
@Shaptic Shaptic added this to the Soroban Stable P20 Release milestone Oct 5, 2023
@mollykarcher mollykarcher moved this from Backlog to Current Sprint in Platform Scrum Oct 10, 2023
@Shaptic Shaptic moved this from Current Sprint to Blocked in Platform Scrum Oct 10, 2023
@Shaptic Shaptic moved this from Blocked to Current Sprint in Platform Scrum Oct 20, 2023
@Shaptic Shaptic moved this from Current Sprint to In Progress in Platform Scrum Oct 20, 2023
@2opremio
Copy link
Contributor

2opremio commented Oct 23, 2023

I would explicitly mention the XDR symbol renames, and the operation BumpFootprintExpiration->ExtendFootpintTTL rename in particular

Otherwise it LGTM!

@Shaptic Shaptic moved this from In Progress to Done in Platform Scrum Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

No branches or pull requests

3 participants