Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create migration notes in Rust docs for v22 #1248

Merged
merged 28 commits into from
Nov 6, 2024
Merged

Create migration notes in Rust docs for v22 #1248

merged 28 commits into from
Nov 6, 2024

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Apr 9, 2024

What

Add migration notes for v22.

Screenshot

soroban_sdk___migrating - Rust

Why

To make the most of docs.rs to provide more complete and thorough migration notes that have not only textual descriptions, but examples and working code that can be tested.

This change adds a GitHub Actions workflow that checks that for any new releases we are preparing, that the migration notes are added.

Close #1048

@leighmcculloch leighmcculloch marked this pull request as ready for review April 9, 2024 11:00
@leighmcculloch leighmcculloch changed the title Start a template for the upcoming v21 release notes Capture release notes in Rust docs Apr 9, 2024
@sisuresh
Copy link
Contributor

sisuresh commented Apr 9, 2024

So in the release workflow, a PR like #1244 will catch the missing notes, and then we'd add it in that PR?

@leighmcculloch
Copy link
Member Author

Yup, that's correct. The job will error indicating that the release notes need writing.

@leighmcculloch
Copy link
Member Author

I think it's also reasonable for us to go the simpler route of making the release notes part of the GitHub Release. If we want to include working examples in the release notes then the Rust docs will help us do that in a reliable way.

sisuresh
sisuresh previously approved these changes Apr 9, 2024
@leighmcculloch leighmcculloch requested a review from dmkozh April 22, 2024 12:40
dmkozh
dmkozh previously approved these changes Apr 22, 2024
@leighmcculloch
Copy link
Member Author

leighmcculloch commented Jul 12, 2024

I missed getting this change in before the last release, and reflecting on this I'm not convinced we're going to be able to maintain keeping this updated and doing it before every release which is an annoying requirement because the release notes get snapshotted at the point in time the tag is made.

Closing because while it seemed like a nice idea I don't expect we'll be able to execute it very well.

We should stick to GitHub release notes, and where-possible include working examples inside the Rust docs (as we do today) for any new feature or changing feature, along with using the rust deprecated annotations that will help folks get to where they need to be via compiler warnings when they're using something that is being replaced with something new.

@leighmcculloch leighmcculloch deleted the i1048 branch July 12, 2024 02:38
@leighmcculloch leighmcculloch restored the i1048 branch July 12, 2024 15:22
@leighmcculloch
Copy link
Member Author

Reopening because it occurred to me that why-not-both. We can do release notes on GitHub releases as we do for the simple release flow, and have a _migrations section of the rust docs dedicated to just breaking changes.

This is more similar to what @ueco-jb suggested in #1048.

@leighmcculloch leighmcculloch marked this pull request as draft July 12, 2024 15:24
@leighmcculloch leighmcculloch changed the title Capture release notes in Rust docs Create major version release notes in Rust docs for v22 Oct 31, 2024
@leighmcculloch leighmcculloch changed the title Create major version release notes in Rust docs for v22 Create migration notes in Rust docs for v22 Oct 31, 2024
@leighmcculloch leighmcculloch dismissed stale reviews from dmkozh and sisuresh October 31, 2024 06:54

redoing

@leighmcculloch leighmcculloch marked this pull request as ready for review November 4, 2024 05:31
@leighmcculloch leighmcculloch added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 8e7e0dd Nov 6, 2024
17 checks passed
@leighmcculloch leighmcculloch deleted the i1048 branch November 6, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create MIGRATION.md file
4 participants