Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support getVersionInfo in the RPC client (rpc.Server) #997

Closed
Tracked by #935
Shaptic opened this issue Jul 1, 2024 · 0 comments · Fixed by #1028
Closed
Tracked by #935

Support getVersionInfo in the RPC client (rpc.Server) #997

Shaptic opened this issue Jul 1, 2024 · 0 comments · Fixed by #1028
Assignees
@psheth9
Labels
rpc-sdk-scrum
Milestone
platform sprint 50

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Jul 1, 2024 •
edited
Loading

The getVersionInfo RPC call was introduced in stellar/stellar-rpc#132 with the following API response:

interface Response {
    version: string;
    commit_hash: string;
    build_time_stamp: string;
    captive_core_version: string;
    protocol_version: number; // uint32
}

Notice that the fields are underscored rather than the camelCase for the other endpoints. This was a mistake on release and will be rectified when Protocol 22 is released by stellar/stellar-rpc#164 to avoid breaking changes in the meantime.
@Shaptic Shaptic mentioned this issue Jul 1, 2024
Closed
@Shaptic Shaptic changed the title Support getFeeStats in the Soroban client Support getFeeStats in the RPC client Jul 1, 2024
@Shaptic Shaptic changed the title Support getFeeStats in the RPC client Support getVersionInfo in the RPC client (rpc.Server) Jul 1, 2024
@Shaptic Shaptic moved this from Backlog to To Do in Platform Scrum Jul 1, 2024
@Shaptic Shaptic added this to the platform sprint 49 milestone Jul 1, 2024
@Shaptic Shaptic mentioned this issue Jul 19, 2024
Closed
@psheth9 psheth9 moved this from To Do to In Progress in Platform Scrum Aug 13, 2024
@psheth9 psheth9 mentioned this issue Aug 13, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Aug 19, 2024
@Shaptic Shaptic mentioned this issue Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psheth9 psheth9

Labels
rpc-sdk-scrum
Projects
Platform Scrum
Status: Done
Milestone
platform sprint 50
Development

Successfully merging a pull request may close this issue.

Add support for getVersionInfo endpoint stellar/js-stellar-sdk
3 participants
@Shaptic @mollykarcher @psheth9