fix: keep MiniMax diagnose output quiet

Author: steipete

Sources/CodexBarCLI/CLIEntry.swift

@@ -30,7 +30,7 @@ enum CodexBarCLI {
 
         do {
             let invocation = try program.resolve(argv: argv)
-            Self.bootstrapLogging(values: invocation.parsedValues)
+            Self.bootstrapLogging(path: invocation.path, values: invocation.parsedValues)
             switch invocation.path {
             case ["usage"]:
                 await self.runUsage(invocation.parsedValues)
@@ -155,12 +155,17 @@ enum CodexBarCLI {
 
     // MARK: - Helpers
 
-    private static func bootstrapLogging(values: ParsedValues) {
+    private static func bootstrapLogging(path: [String], values: ParsedValues) {
+        CodexBarLog.bootstrapIfNeeded(self.loggingConfiguration(path: path, values: values))
+    }
+
+    static func loggingConfiguration(path: [String], values: ParsedValues) -> CodexBarLog.Configuration {
         let isJSON = values.flags.contains("jsonOutput") || values.flags.contains("jsonOnly")
         let verbose = values.flags.contains("verbose")
         let rawLevel = values.options["logLevel"]?.last
         let level = Self.resolvedLogLevel(verbose: verbose, rawLevel: rawLevel)
-        CodexBarLog.bootstrapIfNeeded(.init(destination: .stderr, level: level, json: isJSON))
+        let destination: CodexBarLog.Destination = path == ["diagnose"] ? .discard : .stderr
+        return .init(destination: destination, level: level, json: isJSON)
     }
 
     static func resolvedLogLevel(verbose: Bool, rawLevel: String?) -> CodexBarLog.Level {

Sources/CodexBarCLI/CLIHelpers.swift

@@ -366,6 +366,10 @@ extension CodexBarCLI {
         CommandSignature.describe(CacheOptions())
     }
 
+    static func _diagnoseSignatureForTesting() -> CommandSignature {
+        CommandSignature.describe(DiagnoseOptions())
+    }
+
     static func _configSetAPIKeySignatureForTesting() -> CommandSignature {
         CommandSignature.describe(ConfigSetAPIKeyOptions())
     }

Sources/CodexBarCLI/DiagnoseOptions.swift

@@ -6,6 +6,9 @@ struct DiagnoseOptions: CommanderParsable {
     @Flag(names: [.short("v"), .long("verbose")], help: "Enable verbose logging")
     var verbose: Bool = false
 
+    @Flag(name: .long("json-output"), help: "Emit machine-readable logs")
+    var jsonOutput: Bool = false
+
     @Option(name: .long("log-level"), help: "Set log level (trace|verbose|debug|info|warning|error|critical)")
     var logLevel: String?
 

Sources/CodexBarCore/Logging/CodexBarLog.swift

@@ -4,6 +4,7 @@ import Logging
 public enum CodexBarLog {
     public enum Destination: Sendable {
         case stderr
+        case discard
         case oslog(subsystem: String)
     }
 
@@ -85,6 +86,8 @@ public enum CodexBarLog {
             case .stderr:
                 if config.json { return JSONStderrLogHandler(label: label) }
                 return StreamLogHandler.standardError(label: label)
+            case .discard:
+                return DiscardLogHandler()
             case let .oslog(subsystem):
                 #if canImport(os)
                 return OSLogLogHandler(label: label, subsystem: subsystem)
@@ -154,6 +157,18 @@ public enum CodexBarLog {
     }
 }
 
+private struct DiscardLogHandler: LogHandler {
+    var metadata: Logger.Metadata = [:]
+    var logLevel: Logger.Level = .critical
+
+    subscript(metadataKey metadataKey: String) -> Logger.Metadata.Value? {
+        get { self.metadata[metadataKey] }
+        set { self.metadata[metadataKey] = newValue }
+    }
+
+    func log(event _: LogEvent) {}
+}
+
 public struct CodexBarLogger: Sendable {
     private let logFn: @Sendable (CodexBarLog.Level, String, [String: String]?) -> Void
 

Tests/CodexBarTests/CLIArgumentParsingTests.swift

@@ -64,4 +64,24 @@ struct CLIArgumentParsingTests {
         #expect(!parsed.flags.contains("jsonOutput"))
         #expect(CodexBarCLI._decodeFormatForTesting(from: parsed) == .json)
     }
+
+    @Test
+    func `diagnose accepts json output flag but discards provider logs`() throws {
+        let signature = CodexBarCLI._diagnoseSignatureForTesting()
+        let parser = CommandParser(signature: signature)
+        let parsed = try parser.parse(arguments: [
+            "--provider", "minimax",
+            "--format", "json",
+            "--json-output",
+        ])
+
+        #expect(parsed.flags.contains("jsonOutput"))
+        let config = CodexBarCLI.loggingConfiguration(path: ["diagnose"], values: parsed)
+        switch config.destination {
+        case .discard:
+            break
+        case .stderr, .oslog:
+            Issue.record("diagnose should not emit provider logs beside the safe JSON export")
+        }
+    }
 }