Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots do not show all elements #35

Closed
dmorda opened this issue Mar 7, 2015 · 2 comments
Closed

Screenshots do not show all elements #35

dmorda opened this issue Mar 7, 2015 · 2 comments

Comments

@dmorda
Copy link

dmorda commented Mar 7, 2015

Hi Stefan,

I love photobox and it works in 9 out of 10 cases for me. However, there are a few pages that may take a few milliseconds longer to load because they are doing javascript'ish things with photos such as using Foundation's Interchange. As a result, those photos are not displayed in the output files consistently.

Would there be a way to include a "delay" option that tells the task how long to wait for the page to load before taking the screenshot?

@stefanjudis
Copy link
Owner

@dmorda

Whooops - I kind of missed this one. Sorry for that. :(

Sure thing.

Shouldn't also be a big deal.

The place to tackle might be:

https://github.com/stefanjudis/grunt-photobox/blob/master/tasks/lib/photoboxScript.js#L78

I'm not sure, when I'm available for that, but I'd gladly look over a PR. :)

@sbmadhav
Copy link
Contributor

@dmorda , @stefanjudis : i hope pull request #44 closes out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants