Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Req: Search bar Unicode support #93

Closed
Jonta opened this issue May 8, 2020 · 4 comments
Closed

Req: Search bar Unicode support #93

Jonta opened this issue May 8, 2020 · 4 comments

Comments

@Jonta
Copy link

Jonta commented May 8, 2020

Reproduce:

  1. ddg-search "kümmer"
  2. Open TMP
  3. Search "kümmer" in any view
  4. On "k", the tab is highlighted
  5. But add "ü", and the tab is no longer highlighted
TMP-only Firefox-profile
TMP 5.1.6
Firefox 75.0
macOS 10.11.6
@mastef
Copy link
Contributor

mastef commented May 8, 2020

I don't think this is "unicode support" related. The extension normally works for japanese and other utf-8 characters.

image

What happens if you type in kümmer and then press backspace? Or search for ümmer. Does it highlight the tabs for you? Are you typing in ü natively on your keyboard, or are you holding u long and then using the apple quickselect for special chars?

@Jonta
Copy link
Author

Jonta commented May 21, 2020

Huh, indeed:

  • Type "ümmer"
  • No highlight
  • Backspace
  • Tab is highlighted

And I do press something else on my keyboard to get the ü-character (¨ and then u. Norwegian layout)

@mastef
Copy link
Contributor

mastef commented May 22, 2020

@Jonta I think that's the issue. It happens on my mac as well when I make these special chars ( long-press u and then select ü ). I will have to take a look into this

@mastef
Copy link
Contributor

mastef commented Jun 22, 2020

Should be fixed in c70cf3e and 5.2.0

@mastef mastef closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants