Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save/restore windows: safe to use? #53

Open
yozlet opened this issue Jan 31, 2020 · 12 comments
Open

Save/restore windows: safe to use? #53

yozlet opened this issue Jan 31, 2020 · 12 comments

Comments

@yozlet
Copy link

yozlet commented Jan 31, 2020

I'm enjoying TM+ lots, and the beta save/restore window functionality is very handy. Are there any known problems with it that are stopping from coming out of beta?

@mastef
Copy link
Contributor

mastef commented Feb 3, 2020

@yozlet some people had problems with restoring the windows from the backup json. But have not sent me the .json file to inspect. Although I offered them to just send it to me without the urls in it.

The problem of coming out of experimental stage is that I wasn't able to check their issues, as they haven't sent me their files. Until then I can't classify it as "stable".

So it should be pretty safe to use. If the restoration doesn't work for you, you can always send me the file and I can inspect it and fix it for you.

@yozlet
Copy link
Author

yozlet commented Feb 7, 2020

@mastef Totally understood, thanks for the explanation. I'm fine with you closing this if you like, or leaving it open to track potential problems if people have any.

@tculp
Copy link

tculp commented Feb 21, 2020

When I try to open a saved window (not from a .json file), it just opens a new window with a new tab, failing to restore the saved tabs

@mastef
Copy link
Contributor

mastef commented Feb 21, 2020

@tculp which browser does this happen in? Do you mind exporting your saved windows and sending me the json to [email protected]? You can strip out all urls and titles from the file

@tculp
Copy link

tculp commented Feb 21, 2020

I'm using Firefox. I'll send the json now.

@mastef
Copy link
Contributor

mastef commented Feb 23, 2020

@tculp thanks - I don't seem to have a problem with Chrome. It might be a Firefox build issue. Will look into it

@mastef
Copy link
Contributor

mastef commented Apr 28, 2020

@tculp I'm wondering if this still happens for you in the latest 5.1.6 version? ( released today )

@woahitsraj
Copy link

I'm having this issue on the latest version of firefox developer edition and firefox. Here is my json.
tab-manager-plus-backup-20200614-2154-24.json.zip

@mastef
Copy link
Contributor

mastef commented Jun 15, 2020

@woahitsraj Thank you so much for supplying the .json! Are you trying to restore the session from a popup?

image

Can you try by opening the Tab Manager in "Open in own Tab" or to import this from the options page?

@woahitsraj
Copy link

So it actually works when I open the tab manager in it's own tab but not from the popup

@mastef
Copy link
Contributor

mastef commented Jun 16, 2020

@woahitsraj ok thanks for confirming! That's related to #57

Basically Firefox is not waiting for the file, it just closes the popup instead

@opsoyo
Copy link

opsoyo commented Apr 1, 2022

@woahitsraj ok thanks for confirming! That's related to #57

Basically Firefox is not waiting for the file, it just closes the popup instead

I'd like to append to that. Since #57 is closed, I'll mention here that this is also an issue on Iridium 2021.12.96 (based on Chromium 96.0.4664.110). Purely informational in case anyone else finds this by search. It does successfully import using "Open in own tab".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants