-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local Search #19
Comments
I'd really like to see this feature, therefore, I've started a bounty on Bountysource and donated 20 bucks for it: https://www.bountysource.com/issues/27613093-local-search |
Does anyone want to test the debug-apk-version? |
Search works quite nicely! I find the synchronous updating of the list view very slow, though, and would prefer search on [enter]. |
I am searching the content. The title is generated by the first line of the content, so every titel should be searched, too. Can you give me an example note + search query where it does not work?
Would you prefer a only-search-on-enter or would you like search as you type if it would be asynchron? |
@mrbiber please try the new app-debug.apk - it works now asynchronously and should not cause any performance issues. it is still search-as-you-type. |
Search should definitely be as-you-type. Changing it to only by pressing on enter would make it even slower. There just needs to be proper feedback (like a spinner) and well, it needs to be made faster :) |
I'll try the new apk asap. If the speed is good, then this is, of course, a good solution! |
I strongly aggree. Also there would be a negative performance impact when additional fields must be searched. |
Keep in mind that the file name being different from the first line is very much possible. In fact this happens a lot with desktop syncing. For example, I have some files called »TODO« or similar things, and they have the first thing todo on the top rather than the title again. |
Well this is IMHO a problem that should be addressed in the server app. Maybe by splitting title and content. I will open an issue there. Let's do a first small step and improve the search later when it's in stable branch. |
Searches are now performed asynchronously for performance reasons.
Would be adding a searcher inside the note (for long notes) a good idea? Eg: I have a huge Markdown note for activism with links and descriptions. This would be very useful but I also understand that might be not a very used feature for other people. PS: I don't know if I should open a new issue for this. |
Hi @moshpirit |
I would definitely use an in-note search and think it’s very valuable. :) And hooray already for the note title search! |
Sure! :) |
The text was updated successfully, but these errors were encountered: