Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Search #19

Closed
stefan-niedermann opened this issue Oct 22, 2015 · 14 comments
Closed

Local Search #19

stefan-niedermann opened this issue Oct 22, 2015 · 14 comments
Labels
New Feature UX user experience
Milestone

Comments

@stefan-niedermann
Copy link
Member

  • In the ListView top right should be a search icon
  • Clicking it should expand it to a searchbar.
  • Typing should directly search in the background and display search results in a list
@ghost
Copy link

ghost commented Feb 3, 2016

I'd really like to see this feature, therefore, I've started a bounty on Bountysource and donated 20 bucks for it: https://www.bountysource.com/issues/27613093-local-search

@stefan-niedermann stefan-niedermann added this to the 0.7.0 milestone Feb 3, 2016
@stefan-niedermann
Copy link
Member Author

Does anyone want to test the debug-apk-version?
@HeaDBanGer84 @jancborchardt @mrbiber
bildschirmfoto vom 2016-02-03 14 52 59 bildschirmfoto vom 2016-02-03 14 51 41

@ghost
Copy link

ghost commented Feb 8, 2016

Search works quite nicely! I find the synchronous updating of the list view very slow, though, and would prefer search on [enter].
Also titles/filenames are not included in the search which is probably a frequent use case.

@stefan-niedermann
Copy link
Member Author

Also titles/filenames are not included in the search which is probably a frequent use case.

I am searching the content. The title is generated by the first line of the content, so every titel should be searched, too. Can you give me an example note + search query where it does not work?

Search works quite nicely! I find the synchronous updating of the list view very slow, though, and would prefer search on [enter].

Would you prefer a only-search-on-enter or would you like search as you type if it would be asynchron?

@stefan-niedermann
Copy link
Member Author

@mrbiber please try the new app-debug.apk - it works now asynchronously and should not cause any performance issues. it is still search-as-you-type.

@jancborchardt
Copy link
Member

Search should definitely be as-you-type. Changing it to only by pressing on enter would make it even slower. There just needs to be proper feedback (like a spinner) and well, it needs to be made faster :)

@ghost
Copy link

ghost commented Feb 9, 2016

I'll try the new apk asap. If the speed is good, then this is, of course, a good solution!
As far as the filenames are concerned, this is perhaps an edge case - I'm trying to set up a synchronization between OC notes and a local wiki, where the page title is stored in the file name and thus does not necessarily reappear in the file content. I guess that it's not worth additional code complexity to cover that case.

@stefan-niedermann
Copy link
Member Author

I guess that it's not worth additional code complexity to cover that case.

I strongly aggree. Also there would be a negative performance impact when additional fields must be searched.

@jancborchardt
Copy link
Member

Keep in mind that the file name being different from the first line is very much possible. In fact this happens a lot with desktop syncing.

For example, I have some files called »TODO« or similar things, and they have the first thing todo on the top rather than the title again.

@stefan-niedermann
Copy link
Member Author

Keep in mind that the file name being different from the first line is very much possible. In fact this happens a lot with desktop syncing.

Well this is IMHO a problem that should be addressed in the server app. Maybe by splitting title and content. I will open an issue there. Let's do a first small step and improve the search later when it's in stable branch.

stefan-niedermann added a commit that referenced this issue Feb 9, 2016

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
stefan-niedermann added a commit that referenced this issue Feb 9, 2016
Searches are now performed asynchronously for performance reasons.
@moshpirit
Copy link

Would be adding a searcher inside the note (for long notes) a good idea?

Eg: I have a huge Markdown note for activism with links and descriptions.

This would be very useful but I also understand that might be not a very used feature for other people.

PS: I don't know if I should open a new issue for this.

@stefan-niedermann
Copy link
Member Author

Hi @moshpirit
yeap, please open a new issue. I don't know yet if it's a good idea (how many people would use it?).
But let's discuss :)

@jancborchardt
Copy link
Member

I would definitely use an in-note search and think it’s very valuable. :)

And hooray already for the note title search!

@moshpirit
Copy link

Sure! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature UX user experience
Projects
None yet
Development

No branches or pull requests

3 participants