Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the project compatible with the latest MacOS and Android #11

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Make the project compatible with the latest MacOS and Android #11

merged 3 commits into from
Dec 29, 2022

Conversation

soar
Copy link
Contributor

@soar soar commented Dec 9, 2022

  • Make it compatible with the latest MacOS
  • Make it compatible with the latest Android

@whiteinge
Copy link
Collaborator

whiteinge commented Dec 9, 2022 •
edited
Loading

Interesting, thanks for the updates. I haven't seen this changes yet. What packages provide zipalign and apksigner? It's been convenient to get this done with just the JDK, Apktool, and adb so are these new packages strictly required for the same tasks or can we get by without them somehow? If they're required we should add them to the README.

@soar
Copy link
Contributor Author

soar commented Dec 28, 2022

zipalign and apksigner are parts of Android SDK. This is the new way to sign APK files, without them a file won't be compatible with the latest Android.

@whiteinge
Copy link
Collaborator

Dang, Android SDK is a huge dependency. Will you please update the README with that info? Otherwise this looks good to merge.

@soar
Add a legacy sign option as an alternative for the new way
de56eba 
it can be used with an older Android to skip installing SDK
@whiteinge whiteinge merged commit d3d2999 into steamguard-totp:master Dec 29, 2022
@whiteinge
Copy link
Collaborator

Good stuff. Thank you for the updates!

@soar soar deleted the updates branch December 29, 2022 10:54
@soar soar changed the title Updates Make the project compatible with the latest MacOS and Android Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soar @whiteinge