Skip to content

Commit 3b3572f

Browse files
committed
review fixes
1 parent a924a9a commit 3b3572f

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

packages/status-network/src/components/feedback-popover/dropdown-icon.tsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,14 @@
11
const DropdownIcon = () => {
22
return (
3-
<svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" fill="none">
4-
<g stroke="#A1ABBD" clipPath="url(#a)">
3+
<svg
4+
xmlns="http://www.w3.org/2000/svg"
5+
width="12"
6+
height="12"
7+
fill="none"
8+
aria-hidden="true"
9+
focusable="false"
10+
>
11+
<g stroke="currentColor" clipPath="url(#a)">
512
<circle cx="6" cy="6" r="5" strokeWidth="1.2" />
613
<path strokeWidth="1.1" d="M3.5 5 6 7.5 8.5 5" />
714
</g>

packages/status-network/src/components/feedback-popover/index.tsx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,15 @@ const FeedbackPopover = () => {
1818

1919
return (
2020
<DropdownMenu.Root onOpenChange={setIsOpen} open={isOpen}>
21-
<button className="flex cursor-pointer select-none items-center rounded-10 border border-neutral-70 hover:border-neutral-60">
21+
<button
22+
type="button"
23+
className="flex cursor-pointer select-none items-center rounded-10 border border-neutral-70 hover:border-neutral-60"
24+
>
2225
<div className="flex items-center gap-1 px-2 py-[5px] text-15 font-500 text-white-100 transition">
2326
Share feedback
24-
<DropdownIcon />
27+
<span className="text-neutral-50">
28+
<DropdownIcon />
29+
</span>
2530
</div>
2631
</button>
2732

@@ -37,7 +42,7 @@ const FeedbackPopover = () => {
3742
label={label}
3843
external
3944
onSelect={() => {
40-
window.open(href, '_blank')
45+
window.open(href, '_blank', 'noopener,noreferrer')
4146
}}
4247
/>
4348
))}

0 commit comments

Comments
 (0)