Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display DApp in fullscreen when user scrolls up #8299

Closed
iurimatias opened this issue May 28, 2019 · 5 comments
Closed

Display DApp in fullscreen when user scrolls up #8299

iurimatias opened this issue May 28, 2019 · 5 comments
Assignees
Labels
feature feature requests

Comments

@iurimatias
Copy link
Member

Problem

The status browser takes a lot of screen real estate which distracts from the dapp itself.

Implementation

The approach taken in other mobile browsers is to hide the toolbars when the user scrolls down, and to show the toolbar again when scrolling up. Below is how it looks like in firefox mobile.

image0 (1)

image0 (2)

@andremedeiros
Copy link
Contributor

@hesterbruikman @errorists do we understand how iOS/Android decide to hide the top bar? Sounds like this could be a huge improvement in terms of screen usage (particularly for lower end phones.)

@errorists
Copy link
Contributor

@andremedeiros we just need for it to happen, hiding the toolbar was always there as part of the design for quite a long time now Figma

If we want to hide the address bar along with it, sure we could discuss that. that's like 56 pixels of additional space, 52 for the toolbar.

@hesterbruikman
Copy link
Contributor

@hesterbruikman @errorists do we understand how iOS/Android decide to hide the top bar?

To add, here are 2 related issues. If we solve them, it'll probably make it easier to fix this. I don't think we control the topbar well atm.

The browser address bar is currently out of scope for #8981 I'm not sure why that is though. Probably @rachelhamlin or @flexsurfer can answer that.

@errorists
Copy link
Contributor

errorists commented Oct 28, 2019

Search bar hide on scroll (address bar would than act as the Search bar component)

to only add to that so it's not confused, it's a different behaviour we want for those. Browser's address bar is a predefined Y axis animation that happens when a certain scroll velocity value has been achieved on scroll.
For the Search Bar, it's placed at a -1 position in the list, kinda like a basement. We don't animate it.

@flexsurfer
Copy link
Member

#12394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

No branches or pull requests

6 participants