Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit button is doulbed if try again button is tapped a few times #21043

Closed
VolodLytvynenko opened this issue Aug 14, 2024 · 6 comments · Fixed by #21306
Closed

Edit button is doulbed if try again button is tapped a few times #21043

VolodLytvynenko opened this issue Aug 14, 2024 · 6 comments · Fixed by #21306
Assignees

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Aug 14, 2024

Unfortunately, this issue doesn't happen consistently, and there are no exact steps to reproduce it. Hopefully, the logs will help

Steps:

  1. Recover a user with available assets on at least two networks.
  2. Navigate to the routes generation page.
  3. Enter a value that is available on both networks (e.g., if the user has 1 ETH on Optimism and 1 ETH on Arbitrum, enter 1.5 ETH).
  4. Tap the "Try Again" button multiple times.

Actual Result:

The "Edit" button appears multiple times on the screen.

image

Expected Result:

The "Edit" button should be displayed only once, regardless of how many times the "Try Again" button is tapped

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17

Logs

Status-debug-logs.zip

@J-Son89
Copy link
Contributor

J-Son89 commented Aug 19, 2024

@shivekkhurana, @ilmotta @status-im/mobile-qa @xAlisher - afaik this issue becomes obsolete if it is 2.30 because the simple send will mean this part of the UI no longer exists.

@churik
Copy link
Member

churik commented Aug 26, 2024

That's true, not only this. I'll review all issues after release and if the desicion about simplification hass been made, I can close quite a bunch of issues

@xAlisher
Copy link

@J-Son89 @churik I agree. Hopefully, we’ll reach a final conclusion about the simplification this week or next.

@shivekkhurana
Copy link
Contributor

That's true, not only this. I'll review all issues after release and if the desicion about simplification hass been made, I can close quite a bunch of issues

Simplification doesn't guarantee resolution. The issue might be happening at network level.

@mohsen-ghafouri mohsen-ghafouri self-assigned this Aug 27, 2024
@churik
Copy link
Member

churik commented Aug 28, 2024

This issue is purely front-end, as far as I understood from the conversation with @shivekkhurana yesterday, we are staying with this approach for quite a while, so better to take it

@ilmotta ilmotta added the wallet-core Issues for mobile wallet team label Aug 29, 2024
@churik churik added the blocked label Aug 29, 2024
@mohsen-ghafouri mohsen-ghafouri removed their assignment Aug 29, 2024
@smohamedjavid smohamedjavid self-assigned this Sep 23, 2024
@smohamedjavid
Copy link
Member

Fixed there: #21306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants