You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1st party implementation is coming to dep: golang/dep#121.
Acceptance Criteria
A makefile target is created that fails if there is something in a vendor folder that isn't in Gopkg.lock. Or if dep ensure changes something in the vendor folder.
.travis.yml is updated to have a step of checking dependencies before building or running any tests. (NOTE: Travis restarts builds on every push. If you need to force restarting it and have no changes to commit, just alter the latest commit message with git commit --amend and push. That should do the trick).
The text was updated successfully, but these errors were encountered:
Problem
Currently, our CI process doesn't ensure that the dependencies in
vendor
folder are the same as inGopkg.lock
file.Implementation
The script should run
dep ensure
and then check if anything was changed in thevendor
directory. If so — fail the pipeline.The command to run this script should be
make vendor-check
See this thread for more practical advice.
1st party implementation is coming to
dep
: golang/dep#121.Acceptance Criteria
A makefile target is created that fails if there is something in a
vendor
folder that isn't inGopkg.lock
. Or ifdep ensure
changes something in thevendor
folder..travis.yml
is updated to have a step of checking dependencies before building or running any tests. (NOTE: Travis restarts builds on every push. If you need to force restarting it and have no changes to commit, just alter the latest commit message withgit commit --amend
and push. That should do the trick).The text was updated successfully, but these errors were encountered: