diff --git a/beacon_chain/gossip_processing/block_processor.nim b/beacon_chain/gossip_processing/block_processor.nim index 85b370ce09..45b9dd8dbf 100644 --- a/beacon_chain/gossip_processing/block_processor.nim +++ b/beacon_chain/gossip_processing/block_processor.nim @@ -236,7 +236,6 @@ proc storeBackfillBlock( self.consensusManager.quarantine[].missing.del(signedBlock.root) var columnsOk = true - malformed_cols: HashSet[int] when signedBlock is gloas.SignedBeaconBlock: # For Gloas, we still need to store the columns if they're provided @@ -252,17 +251,14 @@ proc storeBackfillBlock( if columns.len > 0 and kzgCommits.len > 0: for i in 0..= - (self.consensusManager.dag.cfg.NUMBER_OF_COLUMNS div 2) + columnsOk = r.isOk() if not columnsOk: return err(VerifierError.Invalid) @@ -286,9 +282,9 @@ proc storeBackfillBlock( # Only store data columns after successfully establishing block viability. let columns = dataColumnsOpt.valueOr: DataColumnSidecars @[] + debug "Inserting columns into database (backfill)", + indices = columns.mapIt($it[].index) for i in 0.. node.dag.cfg.SAMPLES_PER_SLOT.uint8: + if new_vcus > node.dag.cfg.CUSTODY_REQUIREMENT.uint8: node.network.loadCgcnetMetadataAndEnr(new_vcus) else: - node.network.loadCgcnetMetadataAndEnr(max(node.dag.cfg.SAMPLES_PER_SLOT.uint8, - node.dag.cfg.CUSTODY_REQUIREMENT.uint8)) + node.network.loadCgcnetMetadataAndEnr(node.dag.cfg.CUSTODY_REQUIREMENT.uint8) info "New validator custody count detected", custody_columns = node.dataColumnQuarantine.custodyColumns.len diff --git a/beacon_chain/sync/validator_custody.nim b/beacon_chain/sync/validator_custody.nim index 182a66d3a5..ddf5430f3e 100644 --- a/beacon_chain/sync/validator_custody.nim +++ b/beacon_chain/sync/validator_custody.nim @@ -73,7 +73,7 @@ proc detectNewValidatorCustody*(vcus: ValidatorCustodyRef, newer_columns = vcus.dag.cfg.resolve_columns_from_custody_groups( vcus.network.nodeId, - max(vcus.dag.cfg.SAMPLES_PER_SLOT.uint64, + max(vcus.dag.cfg.CUSTODY_REQUIREMENT.uint64, vcustody)) debug "New validator custody count detected", diff --git a/beacon_chain/validators/message_router.nim b/beacon_chain/validators/message_router.nim index 4d6931411d..dd4fb34ed6 100644 --- a/beacon_chain/validators/message_router.nim +++ b/beacon_chain/validators/message_router.nim @@ -178,11 +178,9 @@ proc routeSignedBeaconBlock*( # Push only those columns to processor for which we custody let metadata = router[].network.metadata.custody_group_count - samples_per_slot = router[].network.cfg.SAMPLES_PER_SLOT custody_columns = router[].network.cfg.resolve_columns_from_custody_groups( - router[].network.nodeId, - max(samples_per_slot, metadata)) + router[].network.nodeId, metadata) var final_columns: seq[ref fulu.DataColumnSidecar] for dc in dataColumns: