replace:DataColumnIdentifier -> DataColumnsByRootIdentifier while root requesting
#7117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheatfate
reviewed
Apr 29, 2025
tersec
reviewed
Apr 30, 2025
tersec
reviewed
Apr 30, 2025
tersec
reviewed
May 1, 2025
| for colresp in columns: | ||
| let block_root = | ||
| hash_tree_root(colresp[].signed_block_header.message) | ||
| if block_root notin idList.mapIt(it.block_root): |
Contributor
There was a problem hiding this comment.
It doesn't have to be in this PR, but in general, this is pointlessly allocating the mapIt-resulting seq.
It only consumes this as an iterator-equivalent and at no point does it need nor should it allocate all of idList.mapIt(it.block_root) (rather, it checks against foo1.block_root, foo2.block_root, in sequence).
Contributor
There was a problem hiding this comment.
Also, it means that it's calculated a bunch of these ahead of the item it might detect a match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum/consensus-specs#4284