Skip to content

Commit e83ebba

Browse files
authored
Update libp2p gossip topic parameters. (#6979)
* Update gossip topic parameters. * Fix nimbus_light_client build. * Update copyright years.
1 parent 1588769 commit e83ebba

File tree

5 files changed

+421
-75
lines changed

5 files changed

+421
-75
lines changed

beacon_chain/light_client.nim

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# beacon_chain
2-
# Copyright (c) 2022-2024 Status Research & Development GmbH
2+
# Copyright (c) 2022-2025 Status Research & Development GmbH
33
# Licensed and distributed under either of
44
# * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
55
# * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
@@ -434,10 +434,8 @@ proc updateGossipStatus*(
434434
if gossipFork >= ConsensusFork.Altair:
435435
let forkDigest = lightClient.forkDigests[].atConsensusFork(gossipFork)
436436
lightClient.network.subscribe(
437-
getLightClientFinalityUpdateTopic(forkDigest),
438-
basicParams)
437+
getLightClientFinalityUpdateTopic(forkDigest), basicParams())
439438
lightClient.network.subscribe(
440-
getLightClientOptimisticUpdateTopic(forkDigest),
441-
basicParams)
439+
getLightClientOptimisticUpdateTopic(forkDigest), basicParams())
442440

443441
lightClient.gossipState = targetGossipState

beacon_chain/networking/eth2_network.nim

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2635,15 +2635,13 @@ proc broadcast(node: Eth2Node, topic: string, msg: auto):
26352635
broadcast(node, topic, gossipEncode(msg))
26362636

26372637
proc subscribeAttestationSubnets*(
2638-
node: Eth2Node, subnets: AttnetBits, forkDigest: ForkDigest) =
2638+
node: Eth2Node, subnets: AttnetBits, forkDigest: ForkDigest,
2639+
topicParams: TopicParams) =
26392640
# https://github.com/ethereum/consensus-specs/blob/v1.5.0-beta.0/specs/phase0/p2p-interface.md#attestations-and-aggregation
2640-
# Nimbus won't score attestation subnets for now, we just rely on block and
2641-
# aggregate which are more stable and reliable
2642-
26432641
for subnet_id, enabled in subnets:
26442642
if enabled:
26452643
node.subscribe(getAttestationTopic(
2646-
forkDigest, SubnetId(subnet_id)), TopicParams.init()) # don't score attestation subnets for now
2644+
forkDigest, SubnetId(subnet_id)), topicParams)
26472645

26482646
proc unsubscribeAttestationSubnets*(
26492647
node: Eth2Node, subnets: AttnetBits, forkDigest: ForkDigest) =

0 commit comments

Comments
 (0)