Cleanup defaultRuntimeConfig use in blockchain_dag tests (#7609)

* Cleanup defaultRuntimeConfig use in blockchain_dag tests

Extract RuntimeConfig into variable to streamline the DAG tests, and fix
a few instances where the cfg was not properly passed to the test DB.

* A couple more in other test files

* Lint

Author: etan-status

tests/consensus_spec/test_fixture_fork_choice.nim

@@ -100,9 +100,9 @@ proc initialLoad(
   ChainDAGRef.preInit(db, forkedState[])
 
   let
+    cfg = forkedState[].kind.genesisTestRuntimeConfig
     validatorMonitor = newClone(ValidatorMonitor.init())
-    dag = ChainDAGRef.init(
-      forkedState[].kind.genesisTestRuntimeConfig, db, validatorMonitor, {})
+    dag = ChainDAGRef.init(cfg, db, validatorMonitor, {})
     fkChoice = newClone(ForkChoice.init(
       dag.getFinalizedEpochRef(), dag.finalizedHead.blck))
 

tests/test_beacon_chain_db.nim

@@ -331,7 +331,7 @@ suite "Beacon chain DB" & preset():
 
     let
       state = newClone(initialize_hashed_beacon_state_from_eth1(
-        defaultRuntimeConfig, mockEth1BlockHash, 0,
+        cfg, mockEth1BlockHash, 0,
         makeInitialDeposits(SLOTS_PER_EPOCH), {skipBlsValidation}))
 
     db.putState(state[].root, state[].data)
@@ -564,8 +564,6 @@ suite "Beacon chain DB" & preset():
     db.close()
 
 suite "Quarantine" & preset():
-  const cfg = defaultRuntimeConfig
-
   setup:
     let
       db = BeaconChainDB.new("", cfg, inMemory = true)