Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename nimbus source directory #2738

Open
pedromiguelmiranda opened this issue Oct 15, 2024 · 2 comments
Open

Rename nimbus source directory #2738

pedromiguelmiranda opened this issue Oct 15, 2024 · 2 comments

Comments

@pedromiguelmiranda
Copy link
Contributor

Now that nimbus binary is renamed to nimbus_execution_client (#2728 ), directory name could also be renamed to nimbus_execution_client (or similar suggestion) and free both the binary and the source directory.

However, there is a trade off regarding log history. All files history under nimbus directory won't be easily accessible via git log command, only via git log --follow (some git clients already implement this, not default with git command tool).

This tradeoff shoud be investigated before the change.

@arnetheduck
Copy link
Member

the case could be made for execution_chain or simply execution here, to complement beacon_chain that we use in eth2

@arnetheduck
Copy link
Member

Also, the makefile target name should be updated to make nimbus_execution_client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants