add id type to feature gate (#268)

kong statsig-io/kong#3459

Author: kat-statsig

client.go

@@ -374,7 +374,7 @@ type GetLayerOptions struct {
 
 func (c *Client) checkGateImpl(user User, name string, context *evalContext) FeatureGate {
 	if !c.verifyUser(user) {
-		return *NewGate(name, false, "", "", nil)
+		return *NewGate(name, false, "", "", "", nil)
 	}
 	user = normalizeUser(user, *c.options)
 	res := c.evaluator.evalGate(user, name, context)
@@ -395,7 +395,7 @@ func (c *Client) checkGateImpl(user User, name string, context *evalContext) Fea
 			c.options.EvaluationCallbacks.ExposureCallback(name, nil)
 		}
 	}
-	return *NewGate(name, res.Value, res.RuleID, res.GroupName, res.EvaluationDetails)
+	return *NewGate(name, res.Value, res.RuleID, res.GroupName, res.IDType, res.EvaluationDetails)
 }
 
 func (c *Client) getConfigImpl(user User, name string, context *evalContext) DynamicConfig {

evaluator.go

@@ -16,8 +16,9 @@ import (
 type evalResult struct {
 	Value                         bool                   `json:"value"`
 	JsonValue                     map[string]interface{} `json:"json_value"`
-	Unsupported               	  bool                   `json:"unsupported"`
+	Unsupported                   bool                   `json:"unsupported"`
 	RuleID                        string                 `json:"rule_id"`
+	IDType                        string                 `json:"id_type"`
 	GroupName                     string                 `json:"group_name"`
 	SecondaryExposures            []SecondaryExposure    `json:"secondary_exposures"`
 	UndelegatedSecondaryExposures []SecondaryExposure    `json:"undelegated_secondary_exposures"`
@@ -372,7 +373,6 @@ func (e *evaluator) eval(user User, spec configSpec, depth int, context *evalCon
 	var exposures = make([]SecondaryExposure, 0)
 	defaultRuleID := "default"
 	var deviceMetadata *DerivedDeviceMetadata
-
 	if spec.Enabled {
 		for _, rule := range spec.Rules {
 			r := e.evalRule(user, rule, depth+1, context)
@@ -397,6 +397,7 @@ func (e *evaluator) eval(user User, spec configSpec, depth int, context *evalCon
 						Value:                         pass,
 						JsonValue:                     configValue,
 						RuleID:                        rule.ID,
+						IDType:                        spec.IDType,
 						GroupName:                     rule.GroupName,
 						SecondaryExposures:            exposures,
 						UndelegatedSecondaryExposures: exposures,
@@ -413,6 +414,7 @@ func (e *evaluator) eval(user User, spec configSpec, depth int, context *evalCon
 					return &evalResult{
 						Value:                 pass,
 						RuleID:                rule.ID,
+						IDType:                spec.IDType,
 						GroupName:             rule.GroupName,
 						SecondaryExposures:    exposures,
 						EvaluationDetails:     evalDetails,
@@ -432,14 +434,16 @@ func (e *evaluator) eval(user User, spec configSpec, depth int, context *evalCon
 			Value:                         false,
 			JsonValue:                     configValue,
 			RuleID:                        defaultRuleID,
+			IDType:                        spec.IDType,
 			SecondaryExposures:            exposures,
 			UndelegatedSecondaryExposures: exposures,
 			EvaluationDetails:             evalDetails,
 			DerivedDeviceMetadata:         deviceMetadata,
 			ConfigVersion:                 spec.ConfigVersion,
 		}
 	}
-	return &evalResult{Value: false, RuleID: defaultRuleID, SecondaryExposures: exposures, DerivedDeviceMetadata: deviceMetadata, ConfigVersion: spec.ConfigVersion}
+	return &evalResult{Value: false, RuleID: defaultRuleID, IDType: spec.IDType,
+		SecondaryExposures: exposures, DerivedDeviceMetadata: deviceMetadata, ConfigVersion: spec.ConfigVersion}
 }
 
 func (e *evaluator) evalDelegate(user User, rule configRule, exposures []SecondaryExposure, depth int, context *evalContext) *evalResult {
@@ -564,7 +568,7 @@ func (e *evaluator) evalCondition(user User, cond configCondition, depth int, co
 	case strings.EqualFold(condType, "unit_id"):
 		value = getUnitID(user, cond.IDType)
 	case strings.EqualFold(condType, "target_app"):
-		if (context.ClientKey != "") {
+		if context.ClientKey != "" {
 			value = context.TargetAppID
 		} else {
 			value = e.store.getAppID()

types.go

@@ -46,6 +46,7 @@ type FeatureGate struct {
 	Name              string             `json:"name"`
 	Value             bool               `json:"value"`
 	RuleID            string             `json:"rule_id"`
+	IDType            string             `json:"id_type"`
 	GroupName         string             `json:"group_name"`
 	EvaluationDetails *EvaluationDetails `json:"evaluation_details"`
 }
@@ -61,11 +62,12 @@ type Layer struct {
 	AllocatedExperimentName string               `json:"allocated_experiment_name"`
 }
 
-func NewGate(name string, value bool, ruleID string, groupName string, evaluationDetails *EvaluationDetails) *FeatureGate {
+func NewGate(name string, value bool, ruleID string, groupName string, idType string, evaluationDetails *EvaluationDetails) *FeatureGate {
 	return &FeatureGate{
 		Name:              name,
 		Value:             value,
 		RuleID:            ruleID,
+		IDType:            idType,
 		GroupName:         groupName,
 		EvaluationDetails: evaluationDetails,
 	}